source-academy / stories-backend

47%

LAST BUILD ON BRANCH main

branch: main

CHANGE BRANCH

x

Reset

Sync Branches

• main
• add-author-fk-non-null
• add-basic-404-handling
• add-db-tests
• add-delete-routes
• add-gorm-type-aliases
• add-group-id-to-context
• add-migrations-check-in-ci
• add-names-to-users
• add-pinned-stories
• add-postgres-to-ci
• add-roles-to-batch-creation
• add-stories-tests
• add-story-group-association
• add-user-batch-creation
• add-user-self-route
• add-users-tests
• add_course_group
• add_group_filter_to_stories
• bump-deps
• change-/groups/{groupId}/users-route
• configure-cors-via-env
• cyy-db_create
• decouple-users
• dependabot/go_modules/github.com/jackc/pgx/v5-5.5.4
• dependabot/go_modules/github.com/lestrrat-go/jwx/v2-2.0.18
• dependabot/go_modules/github.com/lestrrat-go/jwx/v2-2.0.21
• dependabot/go_modules/golang.org/x/crypto-0.17.0
• deployment-docker
• error-handling-stories
• error-handling-users
• finalize-deployment-setup
• fix-cors-error
• fix-deploy-scripts
• fix-env-not-working
• fix-group-id
• fix-misc-stories-bugs
• fix-multitenancy-system
• fix-updating-of-stories
• fix-user-id-context
• go-1-21
• grace-4
• grace-5
• improve-error-handling
• inject-db-middleware
• integrate-user-to-context
• jwt-auth-validation
• make-users-provider-agnostic
• no-error-on-missing-env
• refactor-auth
• refactor-constants
• refactor-db-1
• refactor-db-scripts
• refactor-db-test-runner
• refactor-stories-vc
• refactor-users-vc
• remove-db-variable-in-users
• rena-1
• return-author-name-in-stories
• setup-basic-access-control
• setup-coveralls
• setup-crud-permissions-check
• setup-groups
• setup-nullable-types
• simplify-group-roles
• stories-moderation
• story-update-api-improvements
• test-db
• test-refactor
• update-makefile
• update-readme
• validate-user-on-auth

Build # 9050524776

Build Type

push

github

Committed by web-flow

Commit Message

Change /groups/{group id}/users route (#115)

* fix: inject user id into context in development env

* feat: add ID column to list view of Users

* feat: add role attribute to /groups/{groupId}/users response

a userId could have multiple roles, if it is present in the usergroups table in multiple rows
(with different groupId).

however, since we specify the groupId in the /group/{groupId}/users route, it makes sense that we
only retrieve users that have that groupId.

- in controller, get groupId from context
- for each user obtained from the users table, call GetUserRoleByID function from usergroups model
- store the roles obtained in an array
- pass array to updated ListFrom function from users view, which now include a role attribute
in its JSON response

* fix: DeleteUser in users model

previously, the DeleteUser function was not working as it chained
`.Delete(&user)` after `.First(&user)`. this resulted in a query as
shown, and its corresponding error:

* `ERROR: table name "users" specified more than once (SQLSTATE 42712)
[8.059ms] [rows:1] UPDATE "users" SET "deleted_at"='2024-02-12
20:52:41.02' FROM "users" WHERE id = 4 AND "users"."deleted_at" IS NULL
AND "users"."id" = 4`

the intent of `.First(&user)` was likely to store the user to be deleted
first in the `user` variable with the use of a `SELECT` SQL statement.
however, chaining another method at the end of a finisher method likely
led to some errors (see chaining
[here](https://gorm.io/docs/method_chaining.html)).

thus, this commit attempts to separate the two statements, preserving
the initial intent of storing the user to be deleted before deleting,
and then returning this user.

* feat: function to update row in users model

* feat: function to update row in usergroups model

* feat: add /users/{userID}/role put route

missing validation for parameters, but seemed unnecessary since there is
only one route with parameter validation (crea... (continued)

Run Details

0 of 30 new or added lines in 3 files covered. (0.0%)

286 of 603 relevant lines covered (47.43%)

0.52 hits per line