db5637a3e8e7def9480d8681fa2caa2ecb83d720-PR-146
68%
dev: 68%

Ran 25 Aug 2026 11:08PM UTC

Jobs 1

Files 83

Run time 1min

Badge

Embed ▾

Committed 25 Aug 2026 11:01PM UTC coverage: 68.401%. Remained the same

Build # db5637a3e8e7def9480d8681fa2caa2ecb83d720-PR-146

Build Type

Pull #146

github

Committed by

sgobotta

Commit Message

Fix plain arrows still seeking/adjusting volume on the sliders

The registry's default ignoreInputs guard blocks a scope whenever the
event target's tag is INPUT - meant to stop shortcuts from firing
while typing, but the seek bar and volume slider are also <input>
elements (type="range"), so this scope was silently declining before
ever reaching its own navigation logic whenever either was focused.
Plain arrow keys fell straight through to the native slider behavior
untouched, defeating the self-loop/preventDefault handling added for
them. Opt this scope out of that guard - move()'s own
this.el.contains(active) check already scopes it correctly, since
nothing text-editable lives inside the player controls container.

Adds an integration-level regression test (mounting the hook against
a real fixture and dispatching real keydown events through the
registry) so this class of bug - a scope's own directions being
correct but never reached - can't silently regress again.

Pull Request Pull Request #146: Add a consumer-agnostic keyboard system with explicit grid navigation

Coverage Stats

1472 of 2152 relevant lines covered (68.4%)

30.42 hits per line

Coverage Regressions

Lines	Coverage	∆	File
8	64.86	0.0%	//lib/livedj_web/components/mini_avatar_stack_component.ex
2	47.67	0.0%	//lib/livedj/sessions.ex

Jobs

ID	Job ID	Ran	Files	Coverage
1	db5637a3e8e7def9480d8681fa2caa2ecb83d720-PR-146.1	25 Aug 2026 11:08PM UTC	83	68.4	GitHub Action Run

sgobotta / live_dj / db5637a3e8e7def9480d8681fa2caa2ecb83d720-PR-146
68%
dev: 68%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build db5637a3e8e7def9480d8681fa2caa2ecb83d720-PR-146

sgobotta / live_dj / db5637a3e8e7def9480d8681fa2caa2ecb83d720-PR-146 68% dev: 68%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build db5637a3e8e7def9480d8681fa2caa2ecb83d720-PR-146

sgobotta / live_dj / db5637a3e8e7def9480d8681fa2caa2ecb83d720-PR-146
68%
dev: 68%

README BADGES
x