3722
97%

Ran 06 Jan 2020 04:23AM UTC

Jobs 14

Files 2826

Run time 2465min

Badge

Embed ▾

pending completion

Build # 3722

Build Type

push

travis-ci

Committed by

dblock

Commit Message

delete a reversible stackable values class (#1953)

* delete a reversible stackable values class

The reversible stackable values object was initialized for every endpoint,
however, it is only needed for keeping rescue handlers. The idea is
simple, handlers defined "closer" to an endpoint have higher priority.
That test https://github.com/ruby-grape/grape/blob/master/spec/grape/api_spec.rb#L3215-L3232
demonstrates how it works.

In our project rescue handlers are defined at the top level, so almost every
endpoint keeps the unused object.

The mentioned behavior is easy to achieve with the stackable values object and
the `reverse_each` method. Thus, endpoints keeps less objects and
have less code to be maintained.

Besides that, there are a few other simple performance optimizations.

Run Details

230075 of 232459 relevant lines covered (98.97%)

280.89 hits per line

Jobs

ID	Job ID	Ran	Coverage
2	3722.2 (2.7.0, Gemfile)	07 Jan 2020 09:18PM UTC	98.95	Travis Job 3722.2
3	3722.3 (2.7.0, gemfiles/rack_edge.gemfile)	07 Jan 2020 09:18PM UTC	83.45	Travis Job 3722.3
4	3722.4 (2.7.0, gemfiles/rails_edge.gemfile)	07 Jan 2020 09:19PM UTC	98.96	Travis Job 3722.4
5	3722.5 (2.7.0, gemfiles/rails_5.gemfile)	07 Jan 2020 09:18PM UTC	98.96	Travis Job 3722.5
6	3722.6 (2.7.0, gemfiles/multi_json.gemfile)	07 Jan 2020 09:19PM UTC	60.0	Travis Job 3722.6
7	3722.7 (2.7.0, gemfiles/multi_xml.gemfile)	07 Jan 2020 09:19PM UTC	60.0	Travis Job 3722.7
8	3722.8 (2.6.5, Gemfile)	07 Jan 2020 09:19PM UTC	98.95	Travis Job 3722.8
9	3722.9 (2.6.5, gemfiles/rails_5.gemfile)	07 Jan 2020 09:20PM UTC	98.96	Travis Job 3722.9
10	3722.10 (2.5.7, Gemfile)	07 Jan 2020 09:21PM UTC	98.95	Travis Job 3722.10
11	3722.11 (2.5.7, gemfiles/rails_5.gemfile)	07 Jan 2020 09:21PM UTC	98.96	Travis Job 3722.11
12	3722.12 (2.4.9, Gemfile)	07 Jan 2020 09:21PM UTC	98.95	Travis Job 3722.12
13	3722.13 (2.4.9, gemfiles/rails_5.gemfile)	07 Jan 2020 09:22PM UTC	98.96	Travis Job 3722.13
14	3722.14 (ruby-head)	07 Jan 2020 09:22PM UTC	77.07	Travis Job 3722.14
15	3722.15 (jruby-head)	07 Jan 2020 09:27PM UTC	0.0	Travis Job 3722.15

Source Files on build 3722

Detailed source file information is not available for this build.

ruby-grape / grape / 3722
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3722

ruby-grape / grape / 3722 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3722

ruby-grape / grape / 3722
97%

README BADGES
x