ronelliott / snek

97%

master: 94%

push

github

Fix root command with subcommands rejecting positional args (#6)

* Fix root command with subcommands rejecting positional args

When a root command had both a Run/RunE handler and subcommands, cobra's
legacyArgs validation in Find() would reject any positional arguments
with an "unknown command" error. Auto-apply ArbitraryArgs on the root
command when no custom Args validator has been set to restore expected
behavior.

Also replace cobra.OnInitialize with PersistentPreRunE for logging setup.
cobra.OnInitialize appends to a package-level global, causing initializers
to accumulate across multiple Run() calls (e.g. in tests). PersistentPreRunE
scopes the hook to the command tree and propagates errors through Execute()
instead of calling os.Exit(1) directly.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Address Copilot review comments

- Fix PersistentPreRunE chaining: when both existingPreRunE and
  existingPreRun are set, both now run. Previously existingPreRunE's
  early return skipped existingPreRun entirely.
- Redirect log output to io.Discard in the three new execution tests
  so they don't emit "Logging initialized." to stdout during the test run.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

13 of 20 new or added lines in 1 file covered. (65.0%)

775 of 798 relevant lines covered (97.12%)

10.55 hits per line