pions / webrtc

LAST BUILD ON BRANCH run-inline

branch: run-inline

CHANGE BRANCH

x

Reset

• run-inline
• 3rtx-timer-test
• 501-doc-wasm
• addpacket
• build-osx
• bump-dtls-and-sctp
• bump-sctp
• case-insensitive-ice
• ci-dep
• ci-wasm-dep
• codacy-fix
• combine-tests
• datachannel-api
• datachannel-close
• detach-interface
• dtls-server-verify
• examples-internal
• experiment/dc-connection
• explicit
• explicit-srtp
• export-ice
• fix-modules
• go-modules
• ice-gathering-events
• icecandidateinit
• iceconnectionstate
• initialisms
• integration-test
• ipv6-timeout
• issue-272
• issue-303
• issue-309
• issue-311
• issue-312
• issue-313
• issue-334
• issue-343
• issue-363
• issue-387
• issue-405
• issue-431
• issue-440
• issue-453
• issue-456
• issue-462
• issue-469
• issue-471
• issue-472
• issue-485
• issue-487
• issue-495
• issue-505
• issue-511
• issue-523
• issue-526
• issue-529-check-node-version
• issue-531
• issue-54
• issue-545
• issue-563
• issue-569
• issue515-better-build-tags
• kc5nra/jitterbufferv2
• less-globals
• local-interfaces
• logging
• mainthread
• make-rtcpeerconnection-lock-private
• master
• ntptime
• one-liner
• opuswriter
• ortc
• ortc-dtls
• ortc-fix
• ortc-gather
• ortc-quic
• ortc-sctp
• pions/rtp-v1.0.1
• pipeline-lock
• prefix
• quic-dep
• quic-fix
• quic-fork
• quic-out
• read-buffer
• reject
• rip-defaultapi
• rtcp-fb
• rtp-api
• rtpdump
• sample-builder
• settingsengine
• sfu-ws_deps
• stun-dep
• t1-timer
• test-cleanup
• testability
• timeouts
• topic-data-channel-constructor
• topic-logger-factory
• tracelog
• v1.3.0
• v1.3.0-rc.1
• wasm-detach
• wasm-examples
• wasm-node-tests
• wasm-wiki-link
• wdouglass/experiment
• webrtc-server-master
• writertcp
• wwatson-enable-gocritic

Build # 2632

Build Type

Pull #541

travis-ci

Committed by web-flow

Commit Message

Optimize ice.Agent.getBestPair()

This function should be trivial but profiles show it taking 3-5% of my
application's CPU time. The problem is the constant creation of a
channel for message passing. This function is called by srtp.WriteRTP
for each packet, so it adds up.

My fix was to create a `runInner` function that utilizies a mutex. I
wanted to convert all `run` functions to `runInner` but the code
occasionally deadlocks in unit tests. The package is definitely a
candidate for a rewrite.

```
name           old time/op    new time/op    delta
GetBestPair-8     915ns ± 3%      80ns ± 4%  -91.23%  (p=0.008 n=5+5)

name           old alloc/op   new alloc/op   delta
GetBestPair-8      128B ± 0%       16B ± 0%  -87.50%  (p=0.008 n=5+5)

name           old allocs/op  new allocs/op  delta
GetBestPair-8      3.00 ± 0%      1.00 ± 0%  -66.67%  (p=0.008 n=5+5)
```

Pull Request Pull Request #541: Optimize ice.Agent.getBestPair()

Run Details