2612

Ran 22 Mar 2019 12:09AM UTC

Jobs 1

Files 63

Run time 4s

Badge

Embed ▾

pending completion

Build # 2612

Build Type

push

travis-ci

Committed by

kixelated

Commit Message

Optimize ice.Agent.getBestPair()

This function should be trivial but profiles show it taking 3-5% of my
application's CPU time. The problem is the constant creation of a
channel for message passing. This function is called by srtp.WriteRTP
for each packet, so it adds up.

My fix was to create a `runInner` function that utilizies a mutex. I
wanted to convert all `run` functions to `runInner` but the code
occasionally deadlocks in unit tests. The package is definitely a
candidate for a rewrite.

```
name           old time/op    new time/op    delta
GetBestPair-8     915ns ± 3%      80ns ± 4%  -91.23%  (p=0.008 n=5+5)

name           old alloc/op   new alloc/op   delta
GetBestPair-8      128B ± 0%       16B ± 0%  -87.50%  (p=0.008 n=5+5)

name           old allocs/op  new allocs/op  delta
GetBestPair-8      3.00 ± 0%      1.00 ± 0%  -66.67%  (p=0.008 n=5+5)
```

Run Details

4204 of 5174 relevant lines covered (81.25%)

55.38 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2612.1 (GO111MODULE=on)	22 Mar 2019 12:09AM UTC	0	81.25	Travis Job 2612.1

Source Files on build 2612

Detailed source file information is not available for this build.

pions / webrtc / 2612

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2612

pions / webrtc / 2612

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2612

README BADGES
x