pions / webrtc

81%

master: 81%

LAST BUILD ON BRANCH issue-487

branch: issue-487

CHANGE BRANCH

x

Reset

• issue-487
• 3rtx-timer-test
• 501-doc-wasm
• addpacket
• build-osx
• bump-dtls-and-sctp
• bump-sctp
• case-insensitive-ice
• ci-dep
• ci-wasm-dep
• codacy-fix
• combine-tests
• datachannel-api
• datachannel-close
• detach-interface
• dtls-server-verify
• examples-internal
• experiment/dc-connection
• explicit
• explicit-srtp
• export-ice
• fix-modules
• go-modules
• ice-gathering-events
• icecandidateinit
• iceconnectionstate
• initialisms
• integration-test
• ipv6-timeout
• issue-272
• issue-303
• issue-309
• issue-311
• issue-312
• issue-313
• issue-334
• issue-343
• issue-363
• issue-387
• issue-405
• issue-431
• issue-440
• issue-453
• issue-456
• issue-462
• issue-469
• issue-471
• issue-472
• issue-485
• issue-495
• issue-505
• issue-511
• issue-523
• issue-526
• issue-529-check-node-version
• issue-531
• issue-54
• issue-545
• issue-563
• issue-569
• issue515-better-build-tags
• kc5nra/jitterbufferv2
• less-globals
• local-interfaces
• logging
• mainthread
• make-rtcpeerconnection-lock-private
• master
• ntptime
• one-liner
• opuswriter
• ortc
• ortc-dtls
• ortc-fix
• ortc-gather
• ortc-quic
• ortc-sctp
• pions/rtp-v1.0.1
• pipeline-lock
• prefix
• quic-dep
• quic-fix
• quic-fork
• quic-out
• read-buffer
• reject
• rip-defaultapi
• rtcp-fb
• rtp-api
• rtpdump
• run-inline
• sample-builder
• settingsengine
• sfu-ws_deps
• stun-dep
• t1-timer
• test-cleanup
• testability
• timeouts
• topic-data-channel-constructor
• topic-logger-factory
• tracelog
• v1.3.0
• v1.3.0-rc.1
• wasm-detach
• wasm-examples
• wasm-node-tests
• wasm-wiki-link
• wdouglass/experiment
• webrtc-server-master
• writertcp
• wwatson-enable-gocritic

Build # 2377

Build Type

Pull #488

travis-ci

Committed by web-flow

Commit Message

Fix deadlock on DTLS shutdown

DTLS shutdown deadlocks if Close is called before startup completes,
because the DTLS connection hasn't finished yet we don't have handles
to close anything.

This updates DTLS to follow how SCTP is shutdown, by shutting down the
nextConn (ICE in this case) we can shutdown the subsystem. By closing
ICE first, DTLS (and then SCTP) close properly no matter what state
they are in.

Resolves #487

Pull Request Pull Request #488: Add failing test for DTLS shutdown

Run Details

5 of 5 new or added lines in 2 files covered. (100.0%)

4091 of 5078 relevant lines covered (80.56%)

47.91 hits per line