pions / webrtc

81%

master: 81%

LAST BUILD ON BRANCH ice-gathering-events

branch: ice-gathering-events

CHANGE BRANCH

x

Reset

• ice-gathering-events
• 3rtx-timer-test
• 501-doc-wasm
• addpacket
• build-osx
• bump-dtls-and-sctp
• bump-sctp
• case-insensitive-ice
• ci-dep
• ci-wasm-dep
• codacy-fix
• combine-tests
• datachannel-api
• datachannel-close
• detach-interface
• dtls-server-verify
• examples-internal
• experiment/dc-connection
• explicit
• explicit-srtp
• export-ice
• fix-modules
• go-modules
• icecandidateinit
• iceconnectionstate
• initialisms
• integration-test
• ipv6-timeout
• issue-272
• issue-303
• issue-309
• issue-311
• issue-312
• issue-313
• issue-334
• issue-343
• issue-363
• issue-387
• issue-405
• issue-431
• issue-440
• issue-453
• issue-456
• issue-462
• issue-469
• issue-471
• issue-472
• issue-485
• issue-487
• issue-495
• issue-505
• issue-511
• issue-523
• issue-526
• issue-529-check-node-version
• issue-531
• issue-54
• issue-545
• issue-563
• issue-569
• issue515-better-build-tags
• kc5nra/jitterbufferv2
• less-globals
• local-interfaces
• logging
• mainthread
• make-rtcpeerconnection-lock-private
• master
• ntptime
• one-liner
• opuswriter
• ortc
• ortc-dtls
• ortc-fix
• ortc-gather
• ortc-quic
• ortc-sctp
• pions/rtp-v1.0.1
• pipeline-lock
• prefix
• quic-dep
• quic-fix
• quic-fork
• quic-out
• read-buffer
• reject
• rip-defaultapi
• rtcp-fb
• rtp-api
• rtpdump
• run-inline
• sample-builder
• settingsengine
• sfu-ws_deps
• stun-dep
• t1-timer
• test-cleanup
• testability
• timeouts
• topic-data-channel-constructor
• topic-logger-factory
• tracelog
• v1.3.0
• v1.3.0-rc.1
• wasm-detach
• wasm-examples
• wasm-node-tests
• wasm-wiki-link
• wdouglass/experiment
• webrtc-server-master
• writertcp
• wwatson-enable-gocritic

Build # 2658

Build Type

push

travis-ci

Committed by albrow

Commit Message

Add ICE candidate event handlers

Add OnICECandidate and OnICEGatheringStateChange methods to
PeerConnection. The main goal of this change is to improve API
compatibility with the JavaScript/Wasm bindings. It does not actually
add trickle ICE support or change the ICE candidate gathering process,
which is still synchronous in the Go implementation. Rather, it fires
the appropriate events similar to they way they would be fired in a true
trickle ICE process.

Remove unused OnNegotiationNeeded event handler. This handler is not
required for most applications and would be difficult to implement in
Go. This commit removes the handler from the JavaScript/Wasm bindings,
which leads to a more similar API for Go and JavaScript/Wasm.

Add OnICEGatheringStateChange to the JavaScript/Wasm bindings. Also
changes the Go implementation so that the function signatures match.

Run Details

4112 of 5062 relevant lines covered (81.23%)

52.92 hits per line