• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

pantsbuild / pants / 43783577756
93%

Build:
DEFAULT BRANCH: main
Ran 16 Nov 2026 01:06AM UTC
Jobs 11
Files 1801
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

16 Nov 2026 12:59AM UTC coverage: 93.115% (+0.001%) from 93.114%
43783577756

push

github

web-flow
Fix pnpm workspace installs missing dependencies of workspace dependencies (#23754)

Fixes #23752.

## Problem

In a pnpm workspace, installing the node package for a target only
installed that package's own dependencies. When the package depends on
another workspace package, that package's dependencies were left
uninstalled, so code importing through it failed at runtime (e.g.
`Cannot find package '@invented/leaf'`).

## Change

When Pants installs a pnpm workspace member, it now selects the member
together with its dependencies, using pnpm's `<package>...` filter,
instead of the member alone.

- Only the pnpm install path changes. Ordinary commands, npm and yarn,
root environments and single-package projects keep their current
selectors.
- Release note added in `docs/notes/2.34.x.md`.

## Tests

- New regression test: a workspace `reader -> contract -> leaf`. It
installs through the real rules and runs Node. On current main without
the fix it fails (`Cannot find package '@invented/leaf'`); with the fix
Node prints `42`.
- Scope cases cover installation versus ordinary commands across pnpm,
npm and yarn, and member, root and single environments.
- Verified on main 05181fa320 with the native engine built locally:
25/25 tests in `install_node_package_test.py` and
`nodejs_project_environment_test.py`, lint, MyPy,
`build-support/githooks/pre-push` and `pants --changed-since=HEAD fmt`
all pass.

## AI disclosure

This PR was written primarily by Claude Code; I reviewed and tested it.

36 of 36 new or added lines in 4 files covered. (100.0%)

1 existing line in 1 file now uncovered.

98177 of 105436 relevant lines covered (93.12%)

3.66 hits per line

Coverage Regressions

Lines Coverage ∆ File
1
96.15
-3.85% src/python/pants/backend/tools/preamble/subsystem.py
Jobs
ID Job ID Ran Files Coverage
1 test_python_linux_x86_64_4/10 - 43783577756.1 16 Nov 2026 01:14AM UTC 1254
59.0
GitHub Action Run
2 test_python_linux_x86_64_7/10 - 43783577756.2 16 Nov 2026 01:14AM UTC 1228
51.18
GitHub Action Run
3 test_python_linux_x86_64_8/10 - 43783577756.3 16 Nov 2026 01:15AM UTC 1228
53.42
GitHub Action Run
4 test_python_linux_x86_64_1/10 - 43783577756.4 16 Nov 2026 01:12AM UTC 1224
48.94
GitHub Action Run
5 test_python_linux_x86_64_9/10 - 43783577756.5 16 Nov 2026 01:09AM UTC 1235
54.73
GitHub Action Run
6 test_python_linux_x86_64_2/10 - 43783577756.6 16 Nov 2026 01:10AM UTC 1225
59.27
GitHub Action Run
7 test_python_linux_x86_64_0/10 - 43783577756.7 16 Nov 2026 01:10AM UTC 1245
56.83
GitHub Action Run
8 test_python_linux_x86_64_6/10 - 43783577756.8 16 Nov 2026 01:07AM UTC 1222
49.81
GitHub Action Run
9 test_python_linux_x86_64_3/10 - 43783577756.9 16 Nov 2026 01:11AM UTC 1223
51.85
GitHub Action Run
10 test_python_linux_arm64 - 43783577756.10 16 Nov 2026 01:06AM UTC 1210
53.13
GitHub Action Run
11 test_python_linux_x86_64_5/10 - 43783577756.11 16 Nov 2026 01:09AM UTC 1240
60.43
GitHub Action Run
Source Files on build 43783577756
  • Tree
  • List 1801
  • Changed 16
  • Source Changed 5
  • Coverage Changed 16
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #43783577756
  • 32a5115f on github
  • Prev Build on main (#43783220950)
  • Next Build on main (#43981755983)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc