openvax / datacache

95%

master: 95%

LAST BUILD ON BRANCH feature/cache-root

branch: feature/cache-root

CHANGE BRANCH

x

Reset

• feature/cache-root
• adding-timeout-parameter-and-removing-fasta-helpers
• deslop/py2-travis-leftovers
• docs/clearer-guides
• docs/human-friendly-pass
• docs/public-api-and-quickstart
• docs/reader-oriented-guides
• feat/verified-http-zip-members
• feature/archive-directory-install
• feature/bounded-downloads
• feature/bundle-metadata-inspection
• feature/bundle-store-path
• feature/derived-materialization
• feature/downstream-data-workflows
• feature/fetch-freshness
• feature/fixed-path-file-registry
• feature/inspection-provenance
• feature/platformdirs
• feature/prune-and-local-bundles
• feature/resume-auto
• feature/resume-etag-raw-downloads
• feature/return-stale-on-error
• feature/shared-cache-root
• feature/shared-generation-store
• feature/tqdm-default
• feature/windows-bundles
• fix-17-quote-sql-identifiers
• fix-40-assert-to-raise
• fix-45-sqlite-cross-thread
• fix-49-streaming-download
• fix-flaky-download-test
• fix-lint
• fix-releasing-docs
• fix/archive-content-validation
• fix/bounded-http-retries
• fix/cache-safety-and-legacy-compatibility
• fix/csv-db-names-zip-members-docs
• fix/downstream-compat-readonly-cache
• fix/padded-xdg-cache-home
• fix/reject-empty-downloads
• fix/sqlite-schema-1.10.1
• fix/user-agent
• fix/utf8-byte-cache-names
• fix/verified-downloads
• fix/zip-deflate-drain
• master
• migrate-pyproject-toml
• modernize-py3
• release-1.6.0
• try-using-wget

Build # 38004929620

Build Type

Pull #113

github

Committed by iskandr

Commit Message

Fix review findings in get_cache_root

- A legacy location holds data when it has a file anywhere inside (not
  just one level down), ignoring .DS_Store, Thumbs.db, desktop.ini and
  DataCache's own .datacache-* files; unreadable or looping entries are
  skipped instead of raising.
- A platform directory that already holds data wins over a legacy one,
  so the root no longer flips after a fresh install.
- legacy and override are validated up front whichever rule applies:
  text paths only, non-empty, legacy absolute (a relative one scanned the
  working directory); legacy=None means none; override is stripped and
  ~-expanded like environment values.
- Docs: precedence, raises, the interface reference row, and advice to
  resolve once and pass the root along.

Claude-Session: https://claude.ai/code/session_01Pic7GGifYLP45oZkdYihge

Pull Request Pull Request #113: Resolve a package's cache root in one call (1.24.0)

Coverage Stats

41 of 41 new or added lines in 2 files covered. (100.0%)

3018 of 3183 relevant lines covered (94.82%)

7.58 hits per line