openvax / datacache

74%

master: 79%

LAST BUILD ON BRANCH fix-40-assert-to-raise

branch: fix-40-assert-to-raise

CHANGE BRANCH

x

Reset

• fix-40-assert-to-raise
• adding-timeout-parameter-and-removing-fasta-helpers
• fix-17-quote-sql-identifiers
• fix-45-sqlite-cross-thread
• fix-49-streaming-download
• fix-flaky-download-test
• fix-lint
• fix-releasing-docs
• master
• migrate-pyproject-toml
• modernize-py3
• release-1.6.0
• try-using-wget

Build # 27777669405

Build Type

Pull #51

github

Committed by iskandr

Commit Message

Fix #40: replace runtime asserts with explicit exceptions

assert statements are stripped when Python runs with -O, so they must not
be used for validation that needs to hold in production. Replace the five
runtime asserts in cache.py, common.py, database_table.py and download.py
with explicit if/raise checks (ValueError for bad input, RuntimeError for
a violated postcondition).

Claude-Session: https://claude.ai/code/session_011bzfZPTzWnhAMVD7msyMg1

Pull Request Pull Request #51: Fix #40: replace runtime asserts with explicit exceptions

Coverage Stats

2 of 10 new or added lines in 4 files covered. (20.0%)

2 existing lines in 2 files now uncovered.

313 of 424 relevant lines covered (73.82%)

2.21 hits per line