openbraininstitute / libsonata

93%

master: 93%

LAST BUILD ON BRANCH remove-file-locks

branch: remove-file-locks

CHANGE BRANCH

x

Reset

Sync Branches

• remove-file-locks
• add-docstrings
• add-learning-engine
• cleanup
• cleanup-config-tests
• fix-build
• gnuinstalldirs
• jplanas/cond-modif-sonata-ext
• jplanas/copyright-update
• katta/bluebrain2openbraininstitute
• katta/comp_sets_2
• katta/compartment_set_input
• katta/install_dev
• master
• refs/tags/v0.1.30
• refs/tags/v0.1.31
• rev-hdf5
• scikit-build-core
• test-format
• update-catch2
• update-clang-format
• update-coverage
• update-docstrings
• update-hdf5-v1.14.6
• update-highfive
• update-pybind11
• v0.1.32
• v0.1.33
• v0.1.34
• weji/build_sdist
• weji/duplicate_keys
• weji/electric_fields
• weji/seclamp
• weji/seclamp_more

Build # 23892759807

Build Type

Pull #38

github

Committed by mgeplf

Commit Message

Don't use HDF5's default locking behavior when opening files read only

* HDF5 uses file locks to implement a `Single Writer, Multiple Reader` model
* We expect the SONATA HDF5 files to always be finished reading, so we
  don't benefit from this, and on some files systems, there are a finite
  amount of locks (plus it's a pessimizing default)
* we don't want to rely on `HDF5_USE_FILE_LOCKING` to be set
* see more info: https://support.hdfgroup.org/documentation/hdf5/latest/_file_lock.html
* Note: this requires that any other files opened with the HDF5 library
  be opened with the same flags.  Thus, if `h5py` is used to open the file
  concurrently with `libsonata`, there may be failures if the locking
  flags aren't set the same we are using `use_file_locking=True` and
  `ignore_when_disabled=True`

Pull Request Pull Request #38: Don't use HDF5's default locking behavior when opening files read only

Coverage Stats

17 of 18 new or added lines in 4 files covered. (94.44%)

2480 of 2662 relevant lines covered (93.16%)

51.41 hits per line