openbraininstitute / libsonata / 23850488226

93%

master: 93%

Pull #38

github

Don't use HDF5's default locking behavior when opening files read only

* HDF5 uses file locks to implement a `Single Writer, Multiple Reader` model
* We expect the SONATA HDF5 files to always be finished reading, so we
  don't benefit from this, and on some files systems, there are a finite
  amount of locks (plus it's a pessimizing default)
* we don't want to rely on `HDF5_USE_FILE_LOCKING` to be set
* see more info: https://support.hdfgroup.org/documentation/hdf5/latest/_file_lock.html
* Note: this requires that any other files opened with the HDF5 library
  be opened with the same flags.  Thus, if `h5py` is used to open the file
  concurrently with `libsonata`, there may be failures if the locking
  flags aren't set the same we are using `use_file_locking=True` and
  `ignore_when_disabled=True`

16 of 17 new or added lines in 4 files covered. (94.12%)

2480 of 2662 relevant lines covered (93.16%)

51.41 hits per line