openbraininstitute / libsonata

93%

master: 93%

LAST BUILD ON BRANCH katta/per-report-electrodes-file

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• add-docstrings
• add-learning-engine
• brian2
• cleanup
• cleanup-config-tests
• fix-build
• gnuinstalldirs
• input-poisson
• jplanas/cond-modif-sonata-ext
• jplanas/copyright-update
• katta/bluebrain2openbraininstitute
• katta/comp_sets_2
• katta/compartment_set_input
• katta/install_dev
• katta/per-report-electrodes-file
• katta/preserve-input-names-order
• linux-aarch64
• master
• mechanisms-dir
• nodesets-name
• point-model-dir
• refs/tags/v0.1.30
• refs/tags/v0.1.31
• remove-file-locks
• rev-hdf5
• scikit-build-core
• set_retention_days_for_build_artifacts
• simconf-unspecified
• test-format
• update-catch2
• update-clang-format
• update-coverage
• update-docstrings
• update-hdf5-v1.14.6
• update-highfive
• update-pybind11
• v0.1.32
• v0.1.33
• v0.1.34
• v0.1.35
• v0.1.36
• weji/build_sdist
• weji/duplicate_keys
• weji/electric_fields
• weji/seclamp
• weji/seclamp_more

Build # 26642458106

Build Type

Pull #49

github

Committed by cattabiani

Commit Message

Move electrodes_file from run section to per-report LFP blocks

- Add electrodesFile field to SimulationConfig::Report struct
- Remove electrodesFile field from SimulationConfig::Run struct
- parseRun() rejects electrodes_file with a helpful migration error
- parseReports() parses electrodes_file as mandatory for LFP reports
- Make variable_name optional for LFP reports (ignored by LFP computation)
- Reject electrodes_file on non-LFP report types
- Update Python bindings (move electrodes_file from Run to Report)
- Update test data and add C++/Python tests for new behavior
- Add property tests for non-LFP validation

Pull Request Pull Request #49: Move electrodes_file to per-report LFP blocks

Coverage Stats

16 of 19 new or added lines in 1 file covered. (84.21%)

2523 of 2711 relevant lines covered (93.07%)

50.99 hits per line