mroderick / codebar-planner

95%

master: 95%

LAST BUILD ON BRANCH fix-member-details-validation-order

branch: fix-member-details-validation-order

CHANGE BRANCH

x

Reset

Sync Branches

• fix-member-details-validation-order
• add-docs
• add-editor-config
• add-scout-apm
• add-sitemap-generator
• add-tests-for-2515
• attempt-to-fix-issue-template
• bundle-ignore-junk
• docs/improve-workflow-documentation
• feature/chapters-sidebar-v3
• feature/chapters-sidebar-viewcomponent
• feature/events-upcoming-past
• feature/homepage-events-limit
• feature/seeds-performance-data
• fix-broken-chosen
• fix-duplicate-waiting-list-entries
• fix-error-656-undefined-method-event-for-nil
• fix-missing-authentication-error-translation
• fix/cookie-serializer-migration
• fix/dashboard-eager-loading
• fix/event-description-xss-vulnerability
• fix/events-controller-fixes
• fix/events-sponsors-eager-loading
• fix/find-by-nil-errors
• fix/flaky-listable-tests
• fix/homepage-n-plus-one-eager-loading
• fix/homepage-performance
• fix/member-attending-cache
• fix/render-not-found-json-error
• freeze-postgres-version
• imagemagick-check
• improve-intro-text
• improve-language
• improve-og-tags
• improve-repository-configs
• increase-delayed-job-max-runtime
• issue-2367-workshop-feedback
• issue-2445
• link-to-chapters-from-pills
• lock-gem-platforms
• make-event-rendering-faster
• no-og-tags-on-admin
• optimise-images
• params-expect
• policy-tests
• pr/fix-find-by-nil-errors
• remove-2024-impact-report-banner
• remove-bootsnap
• remove-go-squared
• remove-google-analytics
• remove-meta-partial
• remove-puma-cluster-mode-config
• remove-skylight
• remove-twitter
• remove-unused-i18n-features
• remove-unused-new-relic
• replace-claude-md-with-agents-md
• speedup-ci-tests
• stop-pinning-image-processing
• stop-using-update-attribute
• update-year-for-impact-report
• upgrade-ruby
• use-playwright
• use-rails-7-1-defaults
• workshop-invitation-controller

Build # 21898411228

Build Type

push

github

Committed by mroderick

Commit Message

fix(member): optimize validation and fix logic order in details update

Problem:
- member_params was called 6+ times per request (inefficient)
- Validation was checking original params while attrs were modified
- Confusing control flow made code hard to maintain

Solution:
- Call member_params once and reuse the result
- Pass attrs to validation method instead of re-calling member_params
- Validate BEFORE modifying attributes for clearer logic flow

Performance: Reduced member_params calls from 6 to 1 per request

Test: Added test to verify member_params is called only once

Run Details

8 of 8 new or added lines in 2 files covered. (100.0%)

3232 of 3388 relevant lines covered (95.4%)

44.8 hits per line