mroderick / codebar-planner

95%

master: 95%

LAST BUILD ON BRANCH fix-broken-chosen

branch: fix-broken-chosen

CHANGE BRANCH

x

Reset

Sync Branches

• fix-broken-chosen
• add-docs
• add-editor-config
• add-scout-apm
• add-sitemap-generator
• add-tests-for-2515
• attempt-to-fix-issue-template
• bundle-ignore-junk
• docs/improve-workflow-documentation
• feature/chapters-sidebar-v3
• feature/chapters-sidebar-viewcomponent
• feature/events-upcoming-past
• feature/homepage-events-limit
• feature/seeds-performance-data
• fix-duplicate-waiting-list-entries
• fix-error-656-undefined-method-event-for-nil
• fix-member-details-validation-order
• fix-missing-authentication-error-translation
• fix/cookie-serializer-migration
• fix/dashboard-eager-loading
• fix/event-description-xss-vulnerability
• fix/events-controller-fixes
• fix/events-sponsors-eager-loading
• fix/find-by-nil-errors
• fix/flaky-listable-tests
• fix/homepage-n-plus-one-eager-loading
• fix/homepage-performance
• fix/member-attending-cache
• fix/render-not-found-json-error
• freeze-postgres-version
• imagemagick-check
• improve-intro-text
• improve-language
• improve-og-tags
• improve-repository-configs
• increase-delayed-job-max-runtime
• issue-2367-workshop-feedback
• issue-2445
• link-to-chapters-from-pills
• lock-gem-platforms
• make-event-rendering-faster
• no-og-tags-on-admin
• optimise-images
• params-expect
• policy-tests
• pr/fix-find-by-nil-errors
• remove-2024-impact-report-banner
• remove-bootsnap
• remove-go-squared
• remove-google-analytics
• remove-meta-partial
• remove-puma-cluster-mode-config
• remove-skylight
• remove-twitter
• remove-unused-i18n-features
• remove-unused-new-relic
• replace-claude-md-with-agents-md
• speedup-ci-tests
• stop-pinning-image-processing
• stop-using-update-attribute
• update-year-for-impact-report
• upgrade-ruby
• use-playwright
• use-rails-7-1-defaults
• workshop-invitation-controller

Build # 21806779333

Build Type

push

github

Committed by mroderick

Commit Message

fix: replace broken chosen-rails gem with official Chosen v1.8.7 assets

## Problem

The chosen-rails gem's support-rails-8 branch has broken CoffeeScript
compilation that causes Chosen dropdowns to appear empty despite having
populated <option> elements in the DOM.

The CoffeeScript comprehension syntax was compiling to broken JavaScript
with uninitialized loop variables (`for (undefined; i < len; i++)`),
causing loops to never execute. This affected both option parsing and
DOM rendering.

## Root Cause

CoffeeScript 1.12.2 (from 2016) combined with the support-rails-8
branch produces incorrect JavaScript compilation for comprehension loops.

## Solution

Removed the chosen-rails gem dependency and replaced it with official
pre-compiled Chosen v1.8.7 assets in vendor/:

- vendor/assets/javascripts/chosen.jquery.js
- vendor/assets/stylesheets/chosen.css
- vendor/assets/images/chosen-sprite.png
- vendor/assets/images/chosen-sprite@2x.png

Updated application.js to require chosen.jquery from vendor instead of
the gem.

## Benefits

1. Avoids CoffeeScript compilation issues entirely
2. Removes unnecessary gem dependency
3. Full control over Chosen version
4. Simpler asset pipeline (no gem-based asset resolution)

## Additional Fixes

- Fixed JavaScript syntax error in application.js (chosen() options)
- Fixed script loading order (jQuery before Bootstrap)
- Added blank prompt option to members dropdown

## Testing

Verified working:
- Member directory dropdown (240 members)
- Search/filter functionality
- Keyboard navigation
- Single deselect option

## Future Consideration

This uses the jQuery-dependent Chosen library. Long-term, consider
replacing with a modern JavaScript alternative without jQuery dependency.

Run Details

3238 of 3394 relevant lines covered (95.4%)

44.75 hits per line