mroderick / codebar-planner

95%

master: 95%

LAST BUILD ON BRANCH issue-2367-workshop-feedback

branch: issue-2367-workshop-feedback

CHANGE BRANCH

x

Reset

Sync Branches

• issue-2367-workshop-feedback
• add-docs
• add-editor-config
• add-scout-apm
• add-sitemap-generator
• attempt-to-fix-issue-template
• bundle-ignore-junk
• fix/event-description-xss-vulnerability
• freeze-postgres-version
• imagemagick-check
• improve-intro-text
• improve-language
• improve-repository-configs
• increase-delayed-job-max-runtime
• link-to-chapters-from-pills
• lock-gem-platforms
• make-event-rendering-faster
• optimise-images
• policy-tests
• remove-2024-impact-report-banner
• remove-bootsnap
• remove-go-squared
• remove-google-analytics
• remove-meta-partial
• remove-puma-cluster-mode-config
• remove-skylight
• remove-twitter
• remove-unused-i18n-features
• remove-unused-new-relic
• speedup-ci-tests
• stop-pinning-image-processing
• update-year-for-impact-report
• upgrade-ruby
• use-playwright
• use-rails-7-1-defaults

Build # 21583472964

Build Type

push

github

Committed by mroderick

Commit Message

Fix empty coaches list in workshop feedback form (Issue #2367)

Resolves issue where no coaches appeared in the feedback dropdown when
students tried to submit workshop feedback.

Root cause: The feedback controller was filtering for coaches where
attended=true, but attendance is only marked after organizers manually
verify it. When feedback emails are sent (the day after workshop),
coaches have attending=true but attended=nil.

Changes:
- Updated set_coaches to use accepted_or_attended scope instead of attended
- Added ORDER BY with NULLS LAST to prioritize verified coaches first
- Added test for coaches who RSVPd but haven't been verified yet
- Added test for verified coaches appearing before unverified coaches

This allows students to submit feedback immediately after workshops,
even before organizers verify attendance, while still prioritizing
verified coaches when that data is available.

Fixes #2367

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

3242 of 3406 relevant lines covered (95.18%)

44.19 hits per line