mroderick / codebar-planner / 21898411228

95%

master: 95%

push

github

fix(member): optimize validation and fix logic order in details update

Problem:
- member_params was called 6+ times per request (inefficient)
- Validation was checking original params while attrs were modified
- Confusing control flow made code hard to maintain

Solution:
- Call member_params once and reuse the result
- Pass attrs to validation method instead of re-calling member_params
- Validate BEFORE modifying attributes for clearer logic flow

Performance: Reduced member_params calls from 6 to 1 per request

Test: Added test to verify member_params is called only once

8 of 8 new or added lines in 2 files covered. (100.0%)

3232 of 3388 relevant lines covered (95.4%)

44.8 hits per line