mroderick / codebar-planner

96%

master: 95%

LAST BUILD ON BRANCH fix/render-not-found-json-error

branch: fix/render-not-found-json-error

CHANGE BRANCH

x

Reset

Sync Branches

• fix/render-not-found-json-error
• add-docs
• add-editor-config
• add-scout-apm
• add-sitemap-generator
• add-tests-for-2515
• attempt-to-fix-issue-template
• bundle-ignore-junk
• docs/improve-workflow-documentation
• feature/chapters-sidebar-v3
• feature/chapters-sidebar-viewcomponent
• feature/events-upcoming-past
• feature/homepage-events-limit
• feature/seeds-performance-data
• fix-broken-chosen
• fix-duplicate-waiting-list-entries
• fix-error-656-undefined-method-event-for-nil
• fix-member-details-validation-order
• fix-missing-authentication-error-translation
• fix/cookie-serializer-migration
• fix/dashboard-eager-loading
• fix/event-description-xss-vulnerability
• fix/events-controller-fixes
• fix/events-sponsors-eager-loading
• fix/find-by-nil-errors
• fix/flaky-listable-tests
• fix/homepage-n-plus-one-eager-loading
• fix/homepage-performance
• fix/member-attending-cache
• freeze-postgres-version
• imagemagick-check
• improve-intro-text
• improve-language
• improve-og-tags
• improve-repository-configs
• increase-delayed-job-max-runtime
• issue-2367-workshop-feedback
• issue-2445
• link-to-chapters-from-pills
• lock-gem-platforms
• make-event-rendering-faster
• no-og-tags-on-admin
• optimise-images
• params-expect
• policy-tests
• pr/fix-find-by-nil-errors
• remove-2024-impact-report-banner
• remove-bootsnap
• remove-go-squared
• remove-google-analytics
• remove-meta-partial
• remove-puma-cluster-mode-config
• remove-skylight
• remove-twitter
• remove-unused-i18n-features
• remove-unused-new-relic
• replace-claude-md-with-agents-md
• speedup-ci-tests
• stop-pinning-image-processing
• stop-using-update-attribute
• update-year-for-impact-report
• upgrade-ruby
• use-playwright
• use-rails-7-1-defaults
• workshop-invitation-controller

Build # 23208364850

Build Type

push

github

Committed by mroderick

Commit Message

fix: handle JSON format in render_not_found

Reverts the render_not_found method to use respond_to, matching the pattern
used in the exception handler. This fixes MissingTemplate errors when
requests come in with JSON format (e.g., from API clients).

The previous change (3eeca62d) simplified render_not_found but broke JSON
responses. Now HTML requests get the proper 404 page while API requests
get an empty 404 response.

Adds tests for both HTML and JSON format handling.

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

3335 of 3487 relevant lines covered (95.64%)

46.35 hits per line