mroderick / codebar-planner

95%

master: 95%

LAST BUILD ON BRANCH fix/flaky-tests

branch: fix/flaky-tests

CHANGE BRANCH

x

Reset

Sync Branches

• fix/flaky-tests
• add-docs
• add-editor-config
• add-scout-apm
• add-sitemap-generator
• add-tests-for-2515
• attempt-to-fix-issue-template
• bundle-ignore-junk
• chore/upgrade-premailer
• chore/use-rubygems-sitemap-generator
• chromium-headless-shell
• clean-test-optimizations
• docs/improve-workflow-documentation
• feature/add-eligible-methods-to-chapter
• feature/admin-group-members-table
• feature/chapters-sidebar-v3
• feature/chapters-sidebar-viewcomponent
• feature/delayed-email-async
• feature/eligible-tooltip
• feature/events-upcoming-past
• feature/homepage-events-limit
• feature/meeting-organisers-tomselect
• feature/nginx-plausible-proxy-clean
• feature/plausible-analytics
• feature/seeds-performance-data
• feature/sendgrid-batch-email-design
• feature/tom-select-meeting-invitations
• feature/tom-select-member-search
• feature/tom-select-member-search-clean
• feature/tom-select-member-search-final
• fix-broken-chosen
• fix-duplicate-waiting-list-entries
• fix-error-656-undefined-method-event-for-nil
• fix-member-details-validation-order
• fix-missing-authentication-error-translation
• fix-tom-select-timing-2
• fix-workshop-capacity-checks
• fix/blank-email-validation
• fix/cookie-serializer-migration
• fix/dashboard-eager-loading
• fix/deduplicate-chapter-members
• fix/duplicate-workshop-invitations
• fix/event-description-xss-vulnerability
• fix/events-controller-fixes
• fix/events-sponsors-eager-loading
• fix/find-by-nil-errors
• fix/find-by-nil-errors-v2
• fix/flaky-homepage-test
• fix/flaky-listable-tests
• fix/gravatar-nil-email
• fix/homepage-n-plus-one-eager-loading
• fix/homepage-performance
• fix/invalid-emails
• fix/invitation-log-entry-unique-constraint
• fix/invitation-log-retry-handling
• fix/invitation-log-retry-v2
• fix/member-attending-cache
• fix/monthly-attendance-reminder-delivery
• fix/nil-group-by
• fix/pagy-deprecation
• fix/playwright-version-mismatch
• fix/render-not-found-json-error
• fix/subscription-unique-index
• fix/tc-unauthenticated-handling
• fix/time-dependent-flaky-tests
• fix/unknown-format
• fix/unknown-format-rescue
• fix/workshop-capacity-checks
• fix/workshop-invitation-resilience
• freeze-postgres-version
• imagemagick-check
• improve-intro-text
• improve-language
• improve-og-tags
• improve-repository-configs
• increase-delayed-job-max-runtime
• issue-2367-workshop-feedback
• issue-2445
• link-to-chapters-from-pills
• lock-gem-platforms
• make-event-rendering-faster
• master
• no-og-tags-on-admin
• optimise-images
• params-expect
• policy-tests
• pr/fix-find-by-nil-errors
• refactor/mailer-tests
• remove-2024-impact-report-banner
• remove-bootsnap
• remove-go-squared
• remove-google-analytics
• remove-meta-partial
• remove-puma-cluster-mode-config
• remove-skylight
• remove-twitter
• remove-unused-i18n-features
• remove-unused-new-relic
• replace-claude-md-with-agents-md
• speedup-ci-tests
• speedup-tests
• split-up-how-to-support
• stop-pinning-image-processing
• stop-using-update-attribute
• update-year-for-impact-report
• upgrade-ruby
• use-playwright
• use-rails-7-1-defaults
• workshop-invitation-controller

Build # 25430304156

Build Type

push

github

Committed by mroderick

Commit Message

fix: flaky tests in CI

Fix two flaky tests that were failing intermittently in CI:

1. spec/features/listing_coaches_spec.rb:2
   - Changed to use a workshop with a past date (1.month.ago) instead of
     the default future date to ensure the coach is counted for the current
     year query
   - Added 5 second wait to the expectation for page load timing

2. spec/features/admin/manage_workshop_attendances_spec.rb:25
   - Added explicit wait for '.cancel_attendance' element to be present
     before attempting to click it
   - This ensures the element is rendered before interaction

These changes make the tests more robust in parallel CI execution where
timing and database state can vary between test runs.

Coverage Stats

3524 of 3692 relevant lines covered (95.45%)

47.16 hits per line