mroderick / codebar-planner

96%

master: 95%

LAST BUILD ON BRANCH fix/find-by-nil-errors-v2

branch: fix/find-by-nil-errors-v2

CHANGE BRANCH

x

Reset

Sync Branches

• fix/find-by-nil-errors-v2
• add-docs
• add-editor-config
• add-scout-apm
• add-sitemap-generator
• add-tests-for-2515
• attempt-to-fix-issue-template
• bundle-ignore-junk
• chore/upgrade-premailer
• chore/use-rubygems-sitemap-generator
• chromium-headless-shell
• clean-test-optimizations
• docs/improve-workflow-documentation
• feature/add-eligible-methods-to-chapter
• feature/admin-group-members-table
• feature/chapters-sidebar-v3
• feature/chapters-sidebar-viewcomponent
• feature/default-async-email-delivery
• feature/delayed-email-async
• feature/eligible-tooltip
• feature/events-upcoming-past
• feature/homepage-events-limit
• feature/meeting-organisers-tomselect
• feature/nginx-plausible-proxy-clean
• feature/plausible-analytics
• feature/seeds-performance-data
• feature/sendgrid-batch-email-design
• feature/tom-select-meeting-invitations
• feature/tom-select-member-search
• feature/tom-select-member-search-clean
• feature/tom-select-member-search-final
• fix-broken-chosen
• fix-duplicate-waiting-list-entries
• fix-error-656-undefined-method-event-for-nil
• fix-member-details-validation-order
• fix-missing-authentication-error-translation
• fix-tom-select-timing-2
• fix-workshop-capacity-checks
• fix/blank-email-validation
• fix/cookie-serializer-migration
• fix/dashboard-eager-loading
• fix/deduplicate-chapter-members
• fix/duplicate-workshop-invitations
• fix/event-description-xss-vulnerability
• fix/events-controller-fixes
• fix/events-sponsors-eager-loading
• fix/find-by-nil-errors
• fix/flaky-homepage-test
• fix/flaky-listable-tests
• fix/flaky-tests
• fix/gravatar-nil-email
• fix/homepage-n-plus-one-eager-loading
• fix/homepage-performance
• fix/invalid-emails
• fix/invitation-log-entry-unique-constraint
• fix/invitation-log-retry-handling
• fix/invitation-log-retry-v2
• fix/member-attending-cache
• fix/monthly-attendance-reminder-delivery
• fix/nginx-puma-socket-race
• fix/nil-group-by
• fix/pagy-deprecation
• fix/playwright-version-mismatch
• fix/render-not-found-json-error
• fix/subscription-unique-index
• fix/tc-unauthenticated-handling
• fix/time-dependent-flaky-tests
• fix/unknown-format
• fix/unknown-format-rescue
• fix/workshop-capacity-checks
• fix/workshop-invitation-resilience
• freeze-postgres-version
• imagemagick-check
• improve-intro-text
• improve-language
• improve-og-tags
• improve-repository-configs
• increase-delayed-job-max-runtime
• issue-2367-workshop-feedback
• issue-2445
• link-to-chapters-from-pills
• lock-gem-platforms
• make-event-rendering-faster
• master
• no-og-tags-on-admin
• optimise-images
• params-expect
• policy-tests
• pr/fix-find-by-nil-errors
• refactor/mailer-tests
• remove-2024-impact-report-banner
• remove-bootsnap
• remove-go-squared
• remove-google-analytics
• remove-meta-partial
• remove-puma-cluster-mode-config
• remove-skylight
• remove-twitter
• remove-unused-i18n-features
• remove-unused-new-relic
• replace-claude-md-with-agents-md
• speedup-ci-tests
• speedup-tests
• split-up-how-to-support
• stop-pinning-image-processing
• stop-using-update-attribute
• update-year-for-impact-report
• upgrade-ruby
• use-playwright
• use-rails-7-1-defaults
• workshop-invitation-controller

Build # 24497432815

Build Type

push

github

Committed by mroderick

Commit Message

fix: use find_by! to return 404 for invalid tokens

- Changed find_by to find_by! in before_action set_* methods to raise
  ActiveRecord::RecordNotFound (which Rails converts to 404) instead of
  returning nil and causing NoMethodError

High priority (production crash):
- workshop_invitation_concerns.rb - WorkshopInvitation lookup
- admin/meeting_invitations_controller.rb - MeetingInvitation lookup
- admin/invitations_controller.rb - workshop invitation lookup

Medium priority (potential 500 errors):
- admin/meetings_controller.rb - Meeting lookup by slug
- events_controller.rb - Event lookup by slug
- admin/events_controller.rb - Event lookup by slug

Lower priority:
- invitations_controller.rb:80 - MeetingInvitation lookup in cancel_meeting
- contact_preferences_controller.rb:11 - Contact lookup in update
- feedback_controller.rb:22 - FeedbackRequest lookup in submit

Coverage Stats

9 of 9 new or added lines in 9 files covered. (100.0%)

49 existing lines in 18 files now uncovered.

3489 of 3651 relevant lines covered (95.56%)

46.18 hits per line