metalabdesign / flowtip

87%

master: 57%

LAST BUILD ON BRANCH fix-scroll-jank

branch: fix-scroll-jank

CHANGE BRANCH

x

Reset

• fix-scroll-jank
• 4.x.x
• 5.x.x
• bump-version
• calculate-edge-offset
• comment-typos
• container-detection
• decoupled-render
• disable-travis-email
• es-modules
• fiber-support
• fix-incorrect-edge-detection
• fix-incorrect-rotation
• fix-readme-css
• fix-scrollers
• fix-things
• fix-typo-bug
• flow-lint
• git-links
• master
• more-updates
• prettier
• remove-fbjs
• remove-old-node
• remove-omit-util
• renovate/babel-monorepo
• renovate/babel-plugin-module-resolver-3.x
• renovate/configure
• renovate/enzyme-3.x
• renovate/enzyme-adapter-react-16-1.x
• renovate/eslint-4.x
• renovate/eslint-5.x
• renovate/eslint-config-metalab-10.x
• renovate/eslint-plugin-prettier-2.x
• renovate/eslint-plugin-prettier-3.x
• renovate/flowgen-1.x
• renovate/jest-monorepo
• renovate/lerna-2.x
• renovate/lerna-3.x
• renovate/lerna-monorepo
• renovate/major-jest-monorepo
• renovate/pin-dependencies
• renovate/prettier-1.x
• renovate/react-16.x
• renovate/react-dom-16.x
• renovate/react-monorepo
• renovate/regenerator-runtime-0.x
• renovate/renamer-0.x
• renovate/rimraf-2.x
• renovate/rollup-1.x
• renovate/rollup-plugin-babel-4.x
• renovate/rollup-plugin-commonjs-9.x
• renovate/rollup-plugin-node-resolve-4.x
• renovate/typescript-3.x
• standardize-comments
• static-site
• storybook
• tests
• typescript
• update-eslint-babel
• update-react-versions
• update-tests
• updates
• upgrade-deps
• v5.0.0
• v5.1.0
• v5.2.0
• v5.2.1
• x

Build # 284

Build Type

push

travis-ci

Committed by 10xjs

Commit Message

Fix position jank when constrained to viewport edge

When the target is scrolled outside of the viewport and the tooltip is constrained to the edge of the window, Chrome's behavior of apparently debouncing window scroll events causes the tooltip position to shift around slightly as the user scrolls. This is a consequence of the absolute positioned tooltip being transformed to appear to be fixed to the viewport edge.

To fix this, we detect scenarios where the tooltip is constrained at the viewport edge and the bounds rect is the viewport. In such scenarios, the `position` property of the rendered element is changed from `absolute` to `fixed`, which results in a constant, non-janky style property while the page scroll changes.

Run Details

430 of 507 branches covered (84.81%)

349 of 402 relevant lines covered (86.82%)

43.87 hits per line