metalabdesign / flowtip

71%

master: 57%

LAST BUILD ON BRANCH fix-incorrect-edge-detection

branch: fix-incorrect-edge-detection

CHANGE BRANCH

x

Reset

• fix-incorrect-edge-detection
• 4.x.x
• 5.x.x
• bump-version
• calculate-edge-offset
• comment-typos
• container-detection
• decoupled-render
• disable-travis-email
• es-modules
• fiber-support
• fix-incorrect-rotation
• fix-readme-css
• fix-scroll-jank
• fix-scrollers
• fix-things
• fix-typo-bug
• flow-lint
• git-links
• master
• more-updates
• prettier
• remove-fbjs
• remove-old-node
• remove-omit-util
• renovate/babel-monorepo
• renovate/babel-plugin-module-resolver-3.x
• renovate/configure
• renovate/enzyme-3.x
• renovate/enzyme-adapter-react-16-1.x
• renovate/eslint-4.x
• renovate/eslint-5.x
• renovate/eslint-config-metalab-10.x
• renovate/eslint-plugin-prettier-2.x
• renovate/eslint-plugin-prettier-3.x
• renovate/flowgen-1.x
• renovate/jest-monorepo
• renovate/lerna-2.x
• renovate/lerna-3.x
• renovate/lerna-monorepo
• renovate/major-jest-monorepo
• renovate/pin-dependencies
• renovate/prettier-1.x
• renovate/react-16.x
• renovate/react-dom-16.x
• renovate/react-monorepo
• renovate/regenerator-runtime-0.x
• renovate/renamer-0.x
• renovate/rimraf-2.x
• renovate/rollup-1.x
• renovate/rollup-plugin-babel-4.x
• renovate/rollup-plugin-commonjs-9.x
• renovate/rollup-plugin-node-resolve-4.x
• renovate/typescript-3.x
• standardize-comments
• static-site
• storybook
• tests
• typescript
• update-eslint-babel
• update-react-versions
• update-tests
• updates
• upgrade-deps
• v5.0.0
• v5.1.0
• v5.2.0
• v5.2.1
• x

Build # 54

Build Type

push

travis-ci

Committed by izaakschroeder

Commit Message

Fix incorrect edge detection logic.

It looks like previously `.indexOf !== region` should have been `.indexOf(region) !== -1`. Since incorrect edge flipping to the point of UI breakage doesn't happen that often this went undetected for quite some time. So the logic is now fixed to do the right thing and does so in a way a little more performant than calling `indexOf` on a two-element constant array.

Run Details

97 of 236 branches covered (41.1%)

408 of 572 relevant lines covered (71.33%)

5.54 hits per line