metalabdesign / flowtip

81%

master: 57%

LAST BUILD ON BRANCH fiber-support

branch: fiber-support

CHANGE BRANCH

x

Reset

• fiber-support
• 4.x.x
• 5.x.x
• bump-version
• calculate-edge-offset
• comment-typos
• container-detection
• decoupled-render
• disable-travis-email
• es-modules
• fix-incorrect-edge-detection
• fix-incorrect-rotation
• fix-readme-css
• fix-scroll-jank
• fix-scrollers
• fix-things
• fix-typo-bug
• flow-lint
• git-links
• master
• more-updates
• prettier
• remove-fbjs
• remove-old-node
• remove-omit-util
• renovate/babel-monorepo
• renovate/babel-plugin-module-resolver-3.x
• renovate/configure
• renovate/enzyme-3.x
• renovate/enzyme-adapter-react-16-1.x
• renovate/eslint-4.x
• renovate/eslint-5.x
• renovate/eslint-config-metalab-10.x
• renovate/eslint-plugin-prettier-2.x
• renovate/eslint-plugin-prettier-3.x
• renovate/flowgen-1.x
• renovate/jest-monorepo
• renovate/lerna-2.x
• renovate/lerna-3.x
• renovate/lerna-monorepo
• renovate/major-jest-monorepo
• renovate/pin-dependencies
• renovate/prettier-1.x
• renovate/react-16.x
• renovate/react-dom-16.x
• renovate/react-monorepo
• renovate/regenerator-runtime-0.x
• renovate/renamer-0.x
• renovate/rimraf-2.x
• renovate/rollup-1.x
• renovate/rollup-plugin-babel-4.x
• renovate/rollup-plugin-commonjs-9.x
• renovate/rollup-plugin-node-resolve-4.x
• renovate/typescript-3.x
• standardize-comments
• static-site
• storybook
• tests
• typescript
• update-eslint-babel
• update-react-versions
• update-tests
• updates
• upgrade-deps
• v5.0.0
• v5.1.0
• v5.2.0
• v5.2.1
• x

Build # 217

Build Type

push

travis-ci

Committed by 10xjs

Commit Message

Add support for React 16

`findDOMNode` is slated for deprecation soon, and support in React 16 appears to be partially dropped already.

For us to transition completely away from it, we would need to pass a ref prop down to the provided `content` component, including it as part of the `FlowTip` api. This is less ideal than automatically resolving the correct ref as `findDOMNode` currently does and would make the lib more complicated to use.

Until `findDOMNode` support is dropped completely, or we decide on a clean mechanism for passing the ref around, we rely on a custom `findDOMNOde` function that will safely attempt to detect the rendered node using react fiber internals when necessary. This universally supports React 16 and earlier versions.

(See: https://stackoverflow.com/questions/48062095/update-to-react-16-finddomnode-stops-working#answer-48273014)

Run Details

569 of 878 branches covered (64.81%)

569 of 703 relevant lines covered (80.94%)

20.25 hits per line