metalabdesign / flowtip

88%

master: 57%

LAST BUILD ON BRANCH calculate-edge-offset

branch: calculate-edge-offset

CHANGE BRANCH

x

Reset

• calculate-edge-offset
• tests
• master
• bump-version
• update-eslint-babel
• fix-incorrect-edge-detection
• remove-old-node
• update-react-versions
• fix-incorrect-rotation
• fix-things
• x
• 5.x.x
• 4.x.x
• v5.0.0
• static-site
• disable-travis-email
• upgrade-deps
• remove-omit-util
• remove-fbjs
• flow-lint
• prettier
• fix-readme-css
• fiber-support
• container-detection
• v5.1.0
• update-tests
• fix-typo-bug
• standardize-comments
• comment-typos
• decoupled-render
• fix-scroll-jank
• es-modules
• git-links
• v5.2.0
• updates
• more-updates
• v5.2.1
• fix-scrollers
• renovate/configure
• renovate/pin-dependencies
• renovate/babel-plugin-module-resolver-3.x
• renovate/enzyme-3.x
• renovate/babel-monorepo
• renovate/enzyme-adapter-react-16-1.x
• renovate/eslint-4.x
• renovate/eslint-plugin-prettier-2.x
• renovate/lerna-2.x
• renovate/prettier-1.x
• renovate/react-monorepo
• renovate/react-dom-16.x
• renovate/regenerator-runtime-0.x
• renovate/renamer-0.x
• renovate/rimraf-2.x
• renovate/jest-monorepo
• renovate/eslint-5.x
• renovate/eslint-config-metalab-10.x
• renovate/eslint-plugin-prettier-3.x
• renovate/lerna-3.x
• renovate/major-jest-monorepo
• typescript
• renovate/react-16.x
• renovate/rollup-1.x
• renovate/flowgen-1.x
• storybook
• renovate/typescript-3.x
• renovate/rollup-plugin-commonjs-9.x
• renovate/rollup-plugin-node-resolve-4.x
• renovate/lerna-monorepo
• renovate/rollup-plugin-babel-4.x

Build # 258

Build Type

push

travis-ci

Committed by 10xjs

Commit Message

Include edgeOffset in layout calculation

`edgeOffset` is used to represent a margin at the the bounds rect edge. Previously it was only a prop used within the `FlowTip` react component that was subtracted from the resolved `bounds` rect, effectively shrinking it. This had the undesirable effect of also applying the margin to between the positioned tooltip and viewport edge when the target was outside the viewport.

What we really want the tail side of the tooltip to have its own margin, separate from the body. When the tooltip is positioned at the screen edge, the larger of the two margins will determine the final position.

Run Details

429 of 481 branches covered (89.19%)

347 of 395 relevant lines covered (87.85%)

44.62 hits per line