m-lab / ndt-server
76%

DEFAULT BRANCH: main
Repo Added
Files 36
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: main
CHANGE BRANCH
x

coverage: 75.902% (+0.09%) from 75.811%
25450954111

push

github

web-flow 
feat(ndt7): write integration claims (int_id, key_id) to ClientMetadata (#430)

* feat(ndt7): write integration claims (int_id, key_id) to ClientMetadata

Extract integration claims from request context (set by access token controller)
and append them to ClientMetadata. These flow through JSON results into BigQuery
for per-integration test attribution.

* fix: remove local replace directive from go.mod

* refactor(ndt7): adopt generic custom-claim API from m-lab/access

Replace the integration-specific controller.GetIntegrationClaims /
token.IntegrationClaims types (removed during the m-lab/access#43
refactor) with the new generic controller.GetCustomClaim mechanism.

- Define IntegrationClaims locally in ndt7/handler.
- appendIntegrationMetadata type-asserts controller.GetCustomClaim(ctx)
  to *IntegrationClaims.
- Wire NewCustomClaim through ndt7's controller.Setup call via the new
  controller.WithCustomClaim option.

* chore(go.mod): require m-lab/access at PR #43 head commit

Pins github.com/m-lab/access to the pseudo-version for commit 78d3830
on the m-lab/access#43 branch. Drop this commit (or replace it with a
version bump) once the access PR is merged and tagged.

* refactor(ndt7/handler): improve integration claim handling

- Distinguish missing claim (silent) from wrong type (logged warning)
- Rename integration_claims.go to integrationclaims.go to avoid the
  Go *_GOOS.go file-naming convention
- Cover the unexpected-claim-type branch in tests

* ndt7/handler: exclude int_id and key_id from client metadata

Prevent clients from injecting unverified values for int_id and key_id
URL parameters, which are server-verified claims that should not be
overridable by client-supplied metadata.

https://claude.ai/code/session_01KR7gWP4ApK1hwAwDygmmEU

* chore(go.mod): pin m-lab/access to v0.1.0

* refactor(ndt7/handler): address PR review feedback

- Make ctx the first argument in appendIntegrationMetadata (Go idiom)
- Document why excludeKeyRe filte... (continued)

21 of 21 new or added lines in 2 files covered. (100.0%)

3 existing lines in 1 file now uncovered.

1767 of 2328 relevant lines covered (75.9%)

1.56 hits per line

Relevant lines Covered
2328 RELEVANT LINES 1767 COVERED LINES
1.56 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
25450954111 main feat(ndt7): write integration claims (int_id, key_id) to ClientMetadata (#430) * feat(ndt7): write integration claims (int_id, key_id) to ClientMetadata Extract integration claims from request context (set by access token controller) and append ... push web-flow github
75.9
25385234067 main "Claude PR Assistant workflow" (#431) push web-flow github
75.81
22229108747 main docs: add AGENTS.md with AI contribution guidelines push robertodauria github
75.68
20964978714 main docs: replace Travis CI badge with GitHub Actions badge (#423) push web-flow github
75.68
20961287864 main Bump golang.org/x/oauth2 from 0.5.0 to 0.27.0 in /cmd/generate-schemas (#421) Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.5.0 to 0.27.0. - [Commits](https://github.com/golang/oauth2/compare/v0.5.0...v0.27.0) --- updated-... push web-flow github
75.68
20961021140 main Bump google.golang.org/grpc in /cmd/generate-schemas (#422) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.53.0 to 1.56.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](https://github.com/grpc/grp... push web-flow github
75.68
20960751559 main Bump google.golang.org/protobuf in /cmd/generate-schemas (#420) Bumps google.golang.org/protobuf from 1.28.1 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-version: 1.33.0 dependency-type: indir... push web-flow github
75.68
20960733196 main Bump golang.org/x/net from 0.7.0 to 0.38.0 in /cmd/generate-schemas (#419) * Bump golang.org/x/net from 0.7.0 to 0.38.0 in /cmd/generate-schemas Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.38.0. - [Commits](https://gi... push web-flow github
75.68
20960309393 main Merge pull request #418 from m-lab/sandbox-roberto-update-deps chore: update Go to 1.25 and refresh dependencies push web-flow github
75.68
1665 main All fields are not required (#386) * All fields are not required push web-flow travis-ci-com
81.55
See All Builds (1154)