m-lab / ndt-server / 25450954111

76%

Build Type

push

github

Committed by web-flow

Commit Message

feat(ndt7): write integration claims (int_id, key_id) to ClientMetadata (#430)

* feat(ndt7): write integration claims (int_id, key_id) to ClientMetadata

Extract integration claims from request context (set by access token controller)
and append them to ClientMetadata. These flow through JSON results into BigQuery
for per-integration test attribution.

* fix: remove local replace directive from go.mod

* refactor(ndt7): adopt generic custom-claim API from m-lab/access

Replace the integration-specific controller.GetIntegrationClaims /
token.IntegrationClaims types (removed during the m-lab/access#43
refactor) with the new generic controller.GetCustomClaim mechanism.

- Define IntegrationClaims locally in ndt7/handler.
- appendIntegrationMetadata type-asserts controller.GetCustomClaim(ctx)
  to *IntegrationClaims.
- Wire NewCustomClaim through ndt7's controller.Setup call via the new
  controller.WithCustomClaim option.

* chore(go.mod): require m-lab/access at PR #43 head commit

Pins github.com/m-lab/access to the pseudo-version for commit 78d3830
on the m-lab/access#43 branch. Drop this commit (or replace it with a
version bump) once the access PR is merged and tagged.

* refactor(ndt7/handler): improve integration claim handling

- Distinguish missing claim (silent) from wrong type (logged warning)
- Rename integration_claims.go to integrationclaims.go to avoid the
  Go *_GOOS.go file-naming convention
- Cover the unexpected-claim-type branch in tests

* ndt7/handler: exclude int_id and key_id from client metadata

Prevent clients from injecting unverified values for int_id and key_id
URL parameters, which are server-verified claims that should not be
overridable by client-supplied metadata.

https://claude.ai/code/session_01KR7gWP4ApK1hwAwDygmmEU

* chore(go.mod): pin m-lab/access to v0.1.0

* refactor(ndt7/handler): address PR review feedback

- Make ctx the first argument in appendIntegrationMetadata (Go idiom)
- Document why excludeKeyRe filte... (continued)

Coverage Stats

21 of 21 new or added lines in 2 files covered. (100.0%)

3 existing lines in 1 file now uncovered.

1767 of 2328 relevant lines covered (75.9%)

1.56 hits per line