kubevirt / containerized-data-importer
59%

DEFAULT BRANCH: main
Repo Added
Files 156
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: main
CHANGE BRANCH
x

coverage: 59.064% (-0.01%) from 59.076%
#5655

push

travis-ci

web-flow 
Add InsecureSkipVerify support for ImageIO data source (#3944)

What this PR does / why we need it:

This PR adds support for skipping TLS certificate verification when using
ImageIO as a data source for DataVolumes. This enables warm migrations from
oVirt/RHV providers when "Skip certificate validation" is enabled.

The implementation includes:
- Added InsecureSkipVerify field to DataVolumeSourceImageIO API spec
- Added AnnInsecureSkipVerify annotation for passing the flag to importer pods
- Updated UpdateImageIOAnnotations to set the annotation when enabled
- Modified NewImageioDataSource to accept and use the insecureSkipVerify parameter
- Updated getOvirtClient to use tls.Insecure() when flag is true
- Modified createHTTPClient to configure TLSClientConfig.InsecureSkipVerify
- Updated all test cases to pass the new parameter

After the fix:

Warm migrations from oVirt/RHV providers now work correctly when certificate validation is skipped.
The CDI ImageIO importer can connect to oVirt ImageIO
services without requiring a valid CA certificate in a ConfigMap, as long as the InsecureSkipVerify flag is set to true in the DataVolume spec.

Example DataVolume usage:
```yaml
spec:
  source:
    imageio:
      url: "https://ovirt-engine.example.com/ovirt-engine/api"
      diskId: "disk-uuid"
      secretRef: "ovirt-credentials"
      insecureSkipVerify: true  # Skip TLS certificate validation
```

Which issue(s) this PR fixes:

Jira Ticket: https://issues.redhat.com/browse/CNV-71978

Release note:
```release-note
DataVolumes can now skip TLS certificate verification when importing from oVirt/RHV ImageIO sources
by setting `spec.source.imageio.insecureSkipVerify: true`.
```

Signed-off-by: Elad Hazan <ehazan@redhat.com>

33 of 48 new or added lines in 7 files covered. (68.75%)

4 existing lines in 1 file now uncovered.

17246 of 29199 relevant lines covered (59.06%)

0.65 hits per line

Relevant lines Covered
29199 RELEVANT LINES 17246 COVERED LINES
0.65 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
#5655 main Add InsecureSkipVerify support for ImageIO data source (#3944) What this PR does / why we need it: This PR adds support for skipping TLS certificate verification when using ImageIO as a data source for DataVolumes. This enables warm migrations f... push web-flow travis-ci
59.06
#5631 main Remove CriticalAddonsOnly toleration from the CDI pods (#3909) (#3910) The CriticalAddonsOnly toleration is added to the CDI pods which affects pod scheduling and is against k8s best practices Signed-off-by: Howard Gao <howard.gao@gmail.com> Co-... push web-flow travis-ci
59.08
#5624 main DV Recreated with Wrong Status (#3912) * Add check during updateStatus that prevents DVs from updating its status from a PVC that is marked for deletion Signed-off-by: dsanatar <dsanatar@redhat.com> * add unit test to make sure PVCs marked for ... push web-flow travis-ci
59.09
#5622 main uploadserver: wrap no capacity error (#3931) Previously a generic error was used in case of a lack of capacity error during upload. This commit wraps the returned error instead of overwriting it to provide additional context. Signed-off-by: Adi... push web-flow travis-ci
59.09
#5618 main dataimportcron_test: force pullMethod node for architecture pull test (#3928) Signed-off-by: Adi Aloni <aaloni@redhat.com> push web-flow travis-ci
59.12
#5606 main Add status subresource to StorageProfile CRD (#3863) it includes: 1. Add +kubebuilder:subresource:status annotation to StorageProfile type 2. Update controller to handle status updates separately from spec/metadata 3. Regenerate CRD with status s... push web-flow travis-ci
59.15
#5604 main Add Readiness/Liveness Probes to Operator Pod (#3876) * add liveness and readiness probes that periodically make http get requests to an existing endpoint Signed-off-by: dsanatar <dsanatar@redhat.com> * add new health and ready endpoints for pr... push web-flow travis-ci
59.11
#5603 main Tests: Remove DataVolume to Pod annotation propagation tests (#3911) * Remove DV annotation to transfer pods tests This commit removes several functional tests that check that certain annotations are passed from the DV to the transfer pods. The... push web-flow travis-ci
59.2
#5600 main dataimportcron-controller: fix nil map assignment (#3919) The code path assumed that workloadNodePlacement's NodeSelector map was already initialized. This commit ensures that it is initialized before assignment to avoid a panic when the map is n... push web-flow travis-ci
59.22
#5598 main Oracle Cloud: Set default clone strategy to csi-clone (#3882) Signed-off-by: Alvaro Romero <alromero@redhat.com> push web-flow travis-ci
59.22
See All Builds (5653)