kubevirt / containerized-data-importer

59%

main: 49%

LAST BUILD ON BRANCH fix-key-comparison

branch: fix-key-comparison

CHANGE BRANCH

x

Reset

• fix-key-comparison
• 1-32-kvci
• 1-33-kvci
• 2550-assume-fixed
• 31-deps-bump
• 3466
• 3556
• Fix-functional-tests-ginkgo-args-building
• add-clone-populator-watches
• add-operator-probes
• add-pxcsi-support
• add-test-filter-capability
• add-vcenter-decription-test
• add-vddk-certconfigmapr
• add_cdi-api-dataimportcron-mutate_delete_rbac
• add_prom_unit_tests
• allow-access-cluster-services-csv
• auth
• autoupdate
• bazel-6.5.0
• bazel-builder-skopeo
• bazel-push-images-use-skopeo
• bazel-rules-oci
• bazeldnf-caret-fix
• bugfix/move-applystorageprofile-to-cdi-api
• bugfix/snapshot-volumemode-diff
• build-functest-shebang
• bump-containers-image-34
• bump-go-1.24.0
• cbt-query-usage
• cephfs-typo
• change-cdi-deploy-selectors
• change-metrics-port
• change-termination-message-policy
• chore-remove-deprecated-buildnametocertificate
• clone-pvc-events
• cloner_test_ids
• cnv-44140
• cnv-52722
• cnv-58645
• cnv64424
• comment-fix
• compress-image-binaries
• consolidate-stream-data-to-file
• container_image_poller
• csv-dump-network-policies
• datasource-pointer
• debug-certrotation-ut
• decompose-ds-controller-watches
• dep-update-common-pkg
• dependabot/go_modules/github.com/docker/docker-28.0.0incompatible
• dependabot/go_modules/github.com/go-jose/go-jose/v3-3.0.4
• dependabot/go_modules/github.com/ulikunitz/xz-0.5.14
• dependabot/go_modules/golang.org/x/crypto-0.35.0
• dependabot/go_modules/golang.org/x/net-0.38.0
• dependabot/go_modules/staging/src/kubevirt.io/containerized-data-importer-api/golang.org/x/net-0.33.0
• dependabot/go_modules/staging/src/kubevirt.io/containerized-data-importer-api/golang.org/x/net-0.36.0
• dependabot/go_modules/staging/src/kubevirt.io/containerized-data-importer-api/golang.org/x/net-0.38.0
• deprecation-typo-v2-transfer
• dic-poller-get-acknowledge-arch-digest
• dic_pvc_source
• dic_sa
• dump-network-policies
• dv-events-from-pvc
• dv-recreated-status
• enable_webhook_pvc_rendering_featuregate
• exclude-scratch-pvcs-from-backup
• expose-group-version
• feat/snapshot-restore-sc-selection
• feature/add-status-subresource-to-storageprofile-crd
• fix-cdi-space-calculations
• fix-dataimportcron-nil-map-assignment
• fix-datasource-references
• fix-doc-dv
• fix-doc-sources
• fix-error-formatting
• fix-label-regex
• fix-metric-linter
• fix-multi-stage-import-test
• fix-schedulable-running-condition
• fix-snapshot-restore-size-inflation
• fix-upload-tests
• fix/cephfs_capabilities
• fix/storageprofile-error-message-status
• fix_CDIDataVolumeUnusualRestartCount_alert
• fix_clone_target_size_validation
• fix_dic_image_pull_failed
• fix_dv_bound_cond_unknown
• fix_dv_events_test
• fix_empty_storageprofile_test_event_check
• fix_flaky_dic_snapshot_cond_test
• fix_registry_datasource_import_without_certConfigMap
• fix_storageprofile_rendering
• fix_test_storage_profile_snapshot_source
• fix_vddk_volume_import_source_update_test
• flake-upload-proxy-static
• force-dic-test-pullmethod-node
• gcnv_caps
• http-ds-validate-image-size
• hyperdisk-caps
• ibmc-vpc-block-csi
• imageio_skip_tls
• importer-report-scratch-space-message
• improve-dv-testsc
• issue-3878
• kvci-1-31
• kvci-nfs-fix
• label-datasources-architecture
• label-tests-vmware-and-imageio
• main
• metrics-io-timeout
• move-destructive-flag-to-label-filter
• multi-arch-release
• multiarch-test-images
• mutate_pvc_min_size
• network-policies-mapping-cdi-dnm
• new-builder-1-23
• oci-clone-strategy
• pass-annotation-removal
• portworx_rwx_block
• portworx_rwx_block_conditionally
• propogate-labels-from-dv
• pvc-clone-doc
• rebind-capacity-present
• reconcile-ds-on-reference-update
• reconcile_storageprofile_min_pvc_size_annotation
• register-volume-populators
• release-v1.1
• release-v1.10
• release-v1.11
• release-v1.12
• release-v1.13
• release-v1.14
• release-v1.15
• release-v1.16
• release-v1.17
• release-v1.18
• release-v1.19
• release-v1.2
• release-v1.20
• release-v1.21
• release-v1.22
• release-v1.23
• release-v1.24
• release-v1.25
• release-v1.26
• release-v1.28
• release-v1.3
• release-v1.4
• release-v1.5
• release-v1.6
• release-v1.60
• release-v1.7
• release-v1.8
• release-v1.9
• releases-docs-dead-link
• replace-virt-default-functest
• report-upload-error-message-on-write-error
• required-scc
• revert-3644-portworx_rwx_block
• revert-multi-arch-temporarily
• revert-snap-manual-cleanup
• safe-cwe-79
• scc-volumes-hotloop
• selected-node-tmp-host-assisted
• set_min_pvc_size_per_sc_ann
• sparse-check-tests
• support-multiarch-registry-import
• sync-scc-restricted-v2
• targeted-sync-ci-err
• temp-sc-owner-ref
• test
• test-https-proxy-no-certdir
• test-image-multiarch-manifest
• tinycore-multiarch
• update-builder-go-124
• update-default-fsoverhead
• update_CDIDataVolumeUnusualRestartCount_health_impact_label
• update_CDI_alerts_health_and_eval_time
• update_builder_go_123
• update_oauth_to_027
• update_x_net_0_33_0
• use-operator-observability-toolkit
• v1.60.1
• v1.60.4
• v1.60.5
• v1.61.0
• v1.62.0
• v1.63.0
• v1.63.0-alpha.0
• v1.63.1
• v1.64.0
• vddk-extra-args-crd
• volume-capabilities-oracle
• watch_resource_quota
• webhook-ns-selector
• wrap-upload-server-error-message

Build # #5730

Build Type

Pull #3994

travis-ci

Committed by Acedus

Commit Message

keystore_test: fix flaky RSA key comparison by replacing DeepEqual

The previous UT relied on reflect.DeepEqual to compare rsa.PrivateKey
structs which can be flaky since it compares internal memory state
rather than cryptographic equality which is what the test should be
doing. This commit replaces DeepEqual with the PrivateKey Equal method
which checks whether a key and another key have an equivalent private
exponent and primes.

Signed-off-by: Adi Aloni <aaloni@redhat.com>

Pull Request Pull Request #3994: keystore_test: fix flaky RSA key comparison by replacing DeepEqual

Run Details

17352 of 29539 relevant lines covered (58.74%)

0.65 hits per line