kubevirt / containerized-data-importer

50%

main: 50%

LAST BUILD ON BRANCH fix/cleanup_transfer

branch: fix/cleanup_transfer

CHANGE BRANCH

x

Reset

• fix/cleanup_transfer
• 1-32-kvci
• 1-33-kvci
• 2550-assume-fixed
• 31-deps-bump
• 3466
• 3556
• Fix-functional-tests-ginkgo-args-building
• add-clone-populator-watches
• add-dv-nodeselector-annotation
• add-env-var-for-test-namespace
• add-operator-probes
• add-pprof-endpoints
• add-pxcsi-support
• add-test-filter-capability
• add-test-manifest-node-selector
• add-vcenter-decription-test
• add-vddk-certconfigmapr
• add_cdi-api-dataimportcron-mutate_delete_rbac
• add_cidr_block_list
• add_prom_unit_tests
• allow-access-cluster-services-csv
• ann-pod-service-account
• auth
• autoupdate
• bazel-6.5.0
• bazel-builder-skopeo
• bazel-push-images-use-skopeo
• bazel-rules-oci
• bazeldnf-caret-fix
• block-ownership-llms
• bugfix/dataimportcron-reconciliation-fix
• bugfix/move-applystorageprofile-to-cdi-api
• bugfix/snapshot-volumemode-diff
• bugfix/snapshot_reconcile_when_not_ready
• build-functest-shebang
• bump-containers-image-34
• bump-go-1.24.0
• bump-libnbd-version
• cbt-query-usage
• cephfs-typo
• change-cdi-deploy-selectors
• change-metrics-port
• change-termination-message-policy
• chore-remove-deprecated-buildnametocertificate
• clone-pvc-events
• clone_to_file_min_size_fix
• cloner_test_ids
• cnv-44140
• cnv-52722
• cnv-58645
• cnv-69038
• cnv-main
• cnv64424
• comment-fix
• compress-image-binaries
• consolidate-stream-data-to-file
• container_image_poller
• cr-ready-unit-test
• csv-dump-network-policies
• datasource-pointer
• debug-certrotation-ut
• decompose-ds-controller-watches
• dep-update-common-pkg
• dependabot/go_modules/github.com/docker/docker-28.0.0incompatible
• dependabot/go_modules/github.com/go-jose/go-jose/v3-3.0.4
• dependabot/go_modules/github.com/ulikunitz/xz-0.5.14
• dependabot/go_modules/golang.org/x/crypto-0.35.0
• dependabot/go_modules/golang.org/x/net-0.38.0
• dependabot/go_modules/staging/src/kubevirt.io/containerized-data-importer-api/golang.org/x/net-0.33.0
• dependabot/go_modules/staging/src/kubevirt.io/containerized-data-importer-api/golang.org/x/net-0.36.0
• dependabot/go_modules/staging/src/kubevirt.io/containerized-data-importer-api/golang.org/x/net-0.38.0
• dependabot/go_modules/tools/release-notes/github.com/cloudflare/circl-1.6.3
• dependabot/go_modules/tools/release-notes/github.com/go-git/go-git/v5-5.16.5
• dependabot/go_modules/tools/release-notes/golang.org/x/crypto-0.45.0
• deprecation-typo-v2-transfer
• dev-pvc-rm
• dic-poller-get-acknowledge-arch-digest
• dic_pvc_source
• dic_sa
• dump-network-policies
• dv-events-from-pvc
• dv-recreated-status
• enable-service-links-false
• enable_webhook_pvc_rendering_featuregate
• exclude-scratch-pvcs-from-backup
• expose-group-version
• fail-err-multi-arch
• feat/snapshot-restore-sc-selection
• feature/add-status-subresource-to-storageprofile-crd
• fix-bazel-build-images
• fix-cdi-space-calculations
• fix-cert-collection
• fix-cloner-test-sp-annotation-conflict
• fix-cluster-sync-kind
• fix-clusterwide-ca
• fix-context-leaks-importer
• fix-dataimportcron-nil-map-assignment
• fix-datasource-references
• fix-doc-dv
• fix-doc-sources
• fix-error-formatting
• fix-external-provider-hpp-url
• fix-ingress-config-test-override-wipe
• fix-key-comparison
• fix-label-regex
• fix-metric-linter
• fix-multi-stage-import-test
• fix-rr-names
• fix-schedulable-running-condition
• fix-snapshot-restore-size-inflation
• fix-status-update-conflicts
• fix-upload-tests
• fix/cephfs_capabilities
• fix/storageprofile-error-message-status
• fix_CDIDataVolumeUnusualRestartCount_alert
• fix_clone_target_size_validation
• fix_dic_image_pull_failed
• fix_dv_bound_cond_unknown
• fix_dv_events_test
• fix_empty_storageprofile_test_event_check
• fix_flaky_dic_snapshot_cond_test
• fix_registry_datasource_import_without_certConfigMap
• fix_storageprofile_rendering
• fix_test_storage_profile_snapshot_source
• fix_vddk_volume_import_source_update_test
• flake-upload-proxy-static
• force-dic-test-pullmethod-node
• gce-support-rwo-fs
• gcnv_caps
• ginkgo-no-bazel
• go-workspace
• headless-upload-svc
• hpp-overlay-csi
• http-checksum
• http-ds-validate-image-size
• hyperdisk-caps
• ibmc-vpc-block-csi
• imageio_skip_tls
• importer-report-scratch-space-message
• improve-dv-testsc
• investigate-test-25
• issue-3878
• kvci-1-31
• kvci-35
• kvci-nfs-fix
• label-copy-fix
• label-datasources-architecture
• label-tests-vmware-and-imageio
• main
• metrics-io-timeout
• metricsdocs
• minor_typo
• move-destructive-flag-to-label-filter
• mtv-3514
• mtv-4437
• mtv-5264
• multi-arch-release
• multiarch-test-images
• mutate_pvc_min_size
• nbdkit-replace-password-file-with-pipe
• network-policies-mapping-cdi-dnm
• new-builder-1-23
• nodeselector-fix
• oci-clone-strategy
• open-default-ports-upload-server
• pass-annotation-removal
• portworx_rwx_block
• portworx_rwx_block_conditionally
• propogate-labels-from-dv
• provisioner-aware-vsc-selection-for-dic
• pvc-clone-doc
• rebind-capacity-present
• reconcile-ds-on-reference-update
• reconcile_storageprofile_min_pvc_size_annotation
• register-volume-populators
• release-tool-go
• release-v1.1
• release-v1.10
• release-v1.11
• release-v1.12
• release-v1.13
• release-v1.14
• release-v1.15
• release-v1.16
• release-v1.17
• release-v1.18
• release-v1.19
• release-v1.2
• release-v1.20
• release-v1.21
• release-v1.22
• release-v1.23
• release-v1.24
• release-v1.25
• release-v1.26
• release-v1.28
• release-v1.3
• release-v1.4
• release-v1.5
• release-v1.6
• release-v1.60
• release-v1.7
• release-v1.8
• release-v1.9
• releases-docs-dead-link
• remove-copy-dir
• replace-virt-default-functest
• report-imagepullerr-faster
• report-upload-error-message-on-write-error
• required-scc
• restore-size-hint
• retain-cross-ns
• return_nosniff_header
• revert-3644-portworx_rwx_block
• revert-multi-arch-temporarily
• revert-snap-manual-cleanup
• rulesoci-update-230
• safe-cwe-79
• scc-volumes-hotloop
• scratch-space-pvc-sc
• secure-metrics-endpoints
• seek-hole-detection
• selected-node-tmp-host-assisted
• set_min_pvc_size_per_sc_ann
• sizeless-host-assisted-snap
• sparse-check-tests
• status-imports-to-keep
• storagecapabilities-directpv
• storageprofile_condition
• support-multiarch-registry-import
• sync-scc-restricted-v2
• targeted-sync-ci-err
• temp-sc-owner-ref
• test
• test-https-proxy-no-certdir
• test-image-multiarch-manifest
• test-latest-push
• tinycore-multiarch
• tls-security-profile-propagation
• update-builder-go-124
• update-default-fsoverhead
• update_CDIDataVolumeUnusualRestartCount_health_impact_label
• update_CDI_alerts_health_and_eval_time
• update_builder_go_123
• update_controller_gen_version
• update_oauth_to_027
• update_x_net_0_33_0
• uploadproxyurl-env-var
• use-operator-observability-toolkit
• use-storage-over-pvc-in-tests
• v1.60.1
• v1.60.4
• v1.60.5
• v1.61.0
• v1.62.0
• v1.63.0
• v1.63.0-alpha.0
• v1.63.1
• v1.64.0
• v1.999.0-test.0
• vddk-error-wrapping
• vddk-extra-args-crd
• vddk-warning
• volume-capabilities-oracle
• watch_resource_quota
• webhook-ns-selector
• webhook-uncached-client
• wrap-upload-server-error-message

Build # #5947

Build Type

Pull #4092

travis-ci

Committed by carterpewpew

Commit Message

Fix wrong error variable checked in cleanupTransfer closures

The cancelTransfer and finalizeTransfer closures in pkg/importer/imageio-datasource.go each assigned their error to a local variable (cancelError/finalizeError) but then checked the outer scope `err` instead. This caused actual Cancel/Finalize errors to be silently ignored and could produce spurious error logs from unrelated earlier failures. Fix the conditions and klog.Errorf calls to use the correct local error variables.

Signed-off-by: Jathavedhan M <jathavedhan.m@ibm.com>
Assisted-by: Claude <noreply@anthropic.com>

Pull Request Pull Request #4092: Fix wrong error variable checked in cleanupTransfer closures

Coverage Stats

2 of 4 new or added lines in 1 file covered. (50.0%)

14922 of 30123 relevant lines covered (49.54%)

0.56 hits per line