kaidokert / rm32-private

63%

tmps: 63%

push

github

Replace TransferActions boolean explosion with enum (#40)

* Replace TransferActions boolean explosion with enum

TransferActions had 9 fields with mutually exclusive combinations.
Replace with TransferAction enum (6 variants) + DetectedProtocol
enum + paired frametime Option. Invalid states now unrepresentable.

* Fix 4 review issues: servo_pwm, telemetry flag, newinput, else-if

1. Harness missing shared.set_servo_pwm(true) on servo detection
2. set_send_telemetry only sets true, never clears (matches old behavior)
3. Harness DshotCommand newinput=0 now unconditional
4. Use else-if for mutually exclusive dshot/servo processing

* Fix firmware: gate DShot throttle on EDT_ARMED, add regression test

C firmware (dshot.c) only sets newinput from DShot throttle when
EDT_ARMED is true. The Rust firmware ISR handler was applying throttle
unconditionally — the harness already had the correct guard.

Add edt_armed_throttle_gate.txt blackbox test that verifies:
- EDT_ARMED=0 + throttle=1500 → newinput=0 (rejected)
- EDT_ARMED=1 + throttle=1500 → newinput=1500 (accepted)

This test would have caught the missing gate.

0 of 76 new or added lines in 2 files covered. (0.0%)

3601 of 5704 relevant lines covered (63.13%)

761.5 hits per line