jokius / rook
97%

DEFAULT BRANCH: master
Repo Added
Token FztvBpE9PGBZYM8EyfSxhaCRSAoJ9fITZ regen
Build 7 Last
Files 95
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: master
CHANGE BRANCH
x
Sync Branches

coverage: 97.264% (+0.07%) from 97.196%
30987892519

push

github

jokius 
fix(agent-status): a turn that ends with agents still running is not "done"

`Stop` means the main thread ended its TURN, not that the work is finished. In
a swarm the lead hands the turn back constantly while its backgrounded
teammates keep grinding — "waiting for reports, then the gate" — and the
installed `Stop` → `completed --auto-reset` hook lit the sidebar's done
checkmark and called the user over for nothing.

Neither existing mechanism covers this. The `agent_type` filter drops reports
from subagents; this `completed` comes from the main thread and is legitimate.
The pid ownership check drops reports from a nested agent PROCESS; this one is
the pane's own agent. And no instruction to the agent can fix it: `Stop` fires
AFTER its last action and overwrites whatever it set, and after `Stop` the
agent runs nothing at all.

The payload knows, though. `Stop` carries `background_tasks`, and a live
subagent is an entry with `type` = `subagent` AND `status` = `running` (snapped
live off claude-code 2.1.207; when one finishes its entry DISAPPEARS from the
array rather than flipping status). With one present the wrapper reports
`active --blink` instead, keeping every other flag and dropping only
`--auto-reset`. Nothing needs to re-light the checkmark afterwards: Claude Code
wakes the main thread when the last agent lands, and that next `Stop` carries
an empty array.

Both fields must match on the SAME entry, so this walks the array by index with
`plutil` instead of grepping the payload: with a hung `bun run dev` beside a
finished subagent, `"type":"subagent"` and `"status":"running"` both appear — in
DIFFERENT objects — and a substring match would park the row on `active`
forever. That is not hypothetical; the same class of bug (a nested `agent_type`
inside `background_tasks`) ate a `completed` yesterday, and it has a test now.
A long-running background BASH is deliberately not a subagent for the same
reason: it lives there for hours.

Two accepted trade... (continued)

7216 of 7419 relevant lines covered (97.26%)

4052617.78 hits per line

Relevant lines Covered
7419 RELEVANT LINES 7216 COVERED LINES
4052617.78 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
30987892519 master fix(agent-status): a turn that ends with agents still running is not "done" `Stop` means the main thread ended its TURN, not that the work is finished. In a swarm the lead hands the turn back constantly while its backgrounded teammates keep grind... push jokius github
97.26
30635356145 master docs: deploy the Release build whenever a feature is finished push konayre github
97.2
30511680666 master refactor: split the reconcile machinery out of WorkspaceSidebar The file had four lines of headroom under the 1000-line limit, so any further edit would have broken the lint gate. The reconcile/diff half of `Coordinator` — `RowContent`/`TreeShape... push jokius github
96.86
30462579274 master feat(settings): pair each agent status colour with a shape picker push konayre github
96.83
29405968660 master fix: force the exec bit on installed hook scripts + guard it in tests Defense-in-depth for the previous commit. The installer now chmods every agent-status hook script to 0755 after copying, so an install can't reintroduce the "Permission denied"... push jokius github
96.92
29270923041 master feat: dashboard grid overlay port of upstream agterm 2f6410f (#202) + its follow-up 8c8c9aa (titlebar). A view-only grid of up to 9 LIVE session panes over the window (ceil(sqrt(n)) layout), for watching a flock of agents at once. The cell unit ... push jokius github
97.97
29204470857 master docs: rebrand README, skill, rules and packaging for Rook LICENSE keeps the upstream Umputun copyright and adds the fork's; FUNDING.yml (upstream author's sponsors) removed rather than repointed. push jokius github
97.86
See All Builds (7)

Badge your Repo: rook

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh