jokius / rook / 30511680666
97%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 90
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 96.861% (+0.03%) from 96.834%
30511680666

push

github

jokius 
refactor: split the reconcile machinery out of WorkspaceSidebar

The file had four lines of headroom under the 1000-line limit, so any further
edit would have broken the lint gate. The reconcile/diff half of `Coordinator` —
`RowContent`/`TreeShape`, `reconcile`, the shape and content diffs, the row-content
builders, `rebuildAndReload`, the expand/collapse callbacks and the coalesced
roll-up refresh — moves into `WorkspaceSidebar+Reconcile.swift`. 996 → 763 + 248.

STORED properties stay behind because Swift forbids them in an extension (the
tracked expansion set, the last-shape/last-content snapshots, the lazy icon
caches) — the same constraint the `+RowRendering` split already documents. Reading
them from the extension is what forces ten `private` → internal drops; nothing
became public.

A pure move otherwise: 10 insertions against 243 deletions, all ten being those
visibility lines, comments carried over verbatim — including the two WHYs review
just established, that the roll-up refresh must stay deferred and coalesced, and
that inserting the sole-focused id before `reloadData()` is load-bearing.

Two comments the move itself invalidated are corrected here rather than left to
rot: the drag-drop header no longer calls `roots` private, and the `Model rebuild`
MARK no longer heads a group the rebuild has left.

7005 of 7232 relevant lines covered (96.86%)

4157387.15 hits per line

Coverage Regressions

Lines Coverage ∆ File
23
89.23
 0.37% rookCore/Sources/rookctlKit/SessionCommands.swift
10
97.04
 -0.72% rookCore/Sources/rookCore/ControlDispatcher.swift
4
95.48
 0.21% rookCore/Sources/rookctlKit/SocketClient.swift
Jobs
ID Job ID Ran Files Coverage
1 30511680666.1 90
96.86
 GitHub Action Run
Source Files on build 30511680666