jokius / rook / 30987892519
97%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 95
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 97.264% (+0.07%) from 97.196%
30987892519

push

github

jokius 
fix(agent-status): a turn that ends with agents still running is not "done"

`Stop` means the main thread ended its TURN, not that the work is finished. In
a swarm the lead hands the turn back constantly while its backgrounded
teammates keep grinding — "waiting for reports, then the gate" — and the
installed `Stop` → `completed --auto-reset` hook lit the sidebar's done
checkmark and called the user over for nothing.

Neither existing mechanism covers this. The `agent_type` filter drops reports
from subagents; this `completed` comes from the main thread and is legitimate.
The pid ownership check drops reports from a nested agent PROCESS; this one is
the pane's own agent. And no instruction to the agent can fix it: `Stop` fires
AFTER its last action and overwrites whatever it set, and after `Stop` the
agent runs nothing at all.

The payload knows, though. `Stop` carries `background_tasks`, and a live
subagent is an entry with `type` = `subagent` AND `status` = `running` (snapped
live off claude-code 2.1.207; when one finishes its entry DISAPPEARS from the
array rather than flipping status). With one present the wrapper reports
`active --blink` instead, keeping every other flag and dropping only
`--auto-reset`. Nothing needs to re-light the checkmark afterwards: Claude Code
wakes the main thread when the last agent lands, and that next `Stop` carries
an empty array.

Both fields must match on the SAME entry, so this walks the array by index with
`plutil` instead of grepping the payload: with a hung `bun run dev` beside a
finished subagent, `"type":"subagent"` and `"status":"running"` both appear — in
DIFFERENT objects — and a substring match would park the row on `active`
forever. That is not hypothetical; the same class of bug (a nested `agent_type`
inside `background_tasks`) ate a `completed` yesterday, and it has a test now.
A long-running background BASH is deliberately not a subagent for the same
reason: it lives there for hours.

Two accepted trade... (continued)

7216 of 7419 relevant lines covered (97.26%)

4052617.78 hits per line

Coverage Regressions

Lines Coverage ∆ File
9
94.81
 0.04% rookCore/Sources/rookCore/WindowLibrary.swift
9
95.81
 0.34% rookCore/Sources/rookctlKit/SocketClient.swift
4
97.59
 0.09% rookCore/Sources/rookCore/AppStore+RecentClosed.swift
3
99.43
 -0.08% rookCore/Sources/rookCore/AppStore.swift
2
98.17
 0.09% rookCore/Sources/rookCore/AppStore+Persistence.swift
1
99.1
 -0.0% rookCore/Sources/rookCore/AppStore+PendingClose.swift
Jobs
ID Job ID Ran Files Coverage
1 30987892519.1 95
97.26
 GitHub Action Run
Source Files on build 30987892519