jandelgado / jled

97%

master: 97%

LAST BUILD ON BRANCH fix_end_time_regression_on_avr

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• add_esp32_pinmode_warning
• add_github_link
• add_jled_wasm_info
• add_mbed_support
• add_missing_files_to_docsite
• add_missing_tests
• add_repeat_parameter_to_blink_effect
• add_stm32cube_hal
• add_version_info_to_readme
• add_version_to_docsite_index
• ci_use_test_matrix
• claude
• create_doc_site
• decorrelate_candle_flicker_pseudo_random_offsets
• dependabot/github_actions/all-dependencies-007b9456e6
• dependabot/github_actions/all-dependencies-640176b5ab
• dependabot/github_actions/all-dependencies-696b649f44
• dependabot/github_actions/all-dependencies-6ad358ee1b
• dependabot/github_actions/all-dependencies-6d1c06d137
• fix_arduino_core_mbedos_support
• fix_bug_in_16bit_lut_effect_calculation_on_certain_mcu
• fix_docsite_checkout_detach
• fix_docsite_worktree_ci
• fix_end_of_update_condition
• fix_end_time_regression_on_avr
• fix_esp8266_hd_pwm_handling
• fix_local_act_ci_runs
• fix_pico_hal_in_inverted_setup
• format_code_using_clang-format
• group_documentation_update
• harmonize_idlemode_in_stop_and_pause_across_jled_and_jledgroup
• homogenous_tjledgroup
• impl_jledgroup
• impl_pause_and_resume
• improve_makefile_matrix_build
• initialize_lazily_only_on_stm32
• jled_group_additional_lifecycle_events
• jled_group_lifecycle_events
• jled_lifecycle_events
• make_candle_stateless
• make_time_provider_independent_of_pwm_abstraction
• master
• move_lookup_tables_to_progmem_on_avr
• move_signal_inversion_to_hal
• narrow_eval_time_to_period_t
• new_accelerating_blink_example
• new_long_running_breathe_example
• optimize_scale_function
• refactor_brightness_classes
• refactor_split_header_files
• refactor_test_cases
• refactor_to_separate_time_and_pwm_hal
• reversable_group
• shrink_pio_gh_cache_usage
• support_multiple_resolutions
• switch_to_gcovr
• tjled_lifecycle_api_remaining
• update_migration_guide
• use_act_to_run_testmatrix_locally
• use_enum_in_state_machine
• use_specific_platformio_version_in_ci
• use_test_matrix

Build # 33175613579

Build Type

Pull #193

github

Committed by jandelgado

Commit Message

Compute the effect end time in 32 bits

In Update(), "period + delay_after_" and the following
"cycle_period * num_repetitions_" product were both evaluated in int.
On AVR int is 16 bits wide and uint16_t is unsigned int, so neither
operand promotes to anything wider and both expressions wrap at 65536.
Blink(500, 500).Repeat(100) computed an end time of 34463ms instead of
99999ms, stopping after roughly a third of its intended length.

JLed 4.0 cast the sum to uint32_t. The cast was lost in the 5.0 state
machine rewrite. Give cycle_period an explicit uint32_t type to restore
32 bit arithmetic for both expressions.

Platforms where int is 32 bits are unaffected: the signed and unsigned
products share the same low 32 bits and time_end is uint32_t, so the
computed value is identical there. The added regression test therefore
passes on the host with and without this fix, and only discriminates on
a 16 bit int target.

Pull Request Pull Request #193: fix(avr): compute the effect end time in 32 bits

Coverage Stats

213 of 228 branches covered (93.42%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

660 of 670 relevant lines covered (98.51%)

723.97 hits per line