dnsimple / erldns

84%

LAST BUILD ON BRANCH main

branch: main

CHANGE BRANCH

x

Reset

Sync Branches

• main
• automatic-dependencies-update
• backpressure
• basic_ent_implementation
• bugfix/cache_put_rrset_accepts_zone_record
• bugfix/case_clause_not_normalised
• bugfix/rrsig_timestamp
• bugfix/rrsig_ttls
• bugfix/udp_payload_size
• ci
• cleanup_extra_modules
• cleanups
• dependabot/github_actions/actions/checkout-5
• dependabot/github_actions/nosborn/github-action-markdown-cli-3.5.0
• dependencies
• design
• dnstest
• documentation
• edns0_truncated_record
• empty-rrsig
• ent-rfc
• erldns_handler
• erldns_txt_removal
• event_handler
• expand_linter
• feat/custom-admin-api-middlewares
• feature/cds-cdnskey-ksk-rrsig
• fix/map_nsec_rr_types
• fix_min_packet_size
• fixes
• handlers_improvements
• improvements
• linting
• logger
• logger_domains
• mailbox_lengths
• metrics
• network/tcp
• network_performance
• nsec/custom-handlers
• nsec/implementation
• nsec/preparations
• packet_cache_rework
• pipeline_exception_telemetry
• pipelines
• pipelines_question_filter
• prepare_v7
• refactoring/dns_erlang
• release
• release-8.0
• resolver_split
• singletons
• soa-cache
• task/bump-dnstest
• throttle_table_rework
• throws_as_errors_mangling
• tlsa
• tmp
• update_dns_erlang
• v8-rc6
• zone/cache
• zone/cleanups
• zone/codec
• zone/loader
• zones

Build # 17854713342

Build Type

push

github

Committed by web-flow

Commit Message

Do not put empty RRSIG in the cache (#278)

When deleting records, an empty list could be a value for an RRSIG record that
would be put in the cache. This could happen even if the zone had no DNSSEC.
Because of how the "getters" from ETS worked (for example pattern_zone_dname/2)
by appending the resulting record list, this empty RRSIG record would not
appear usually. However, it would get counted as an existing record, which could
lead to bugs.

Run Details

2 of 3 new or added lines in 1 file covered. (66.67%)

2 existing lines in 1 file now uncovered.

1295 of 1536 relevant lines covered (84.31%)

1304.33 hits per line