dnsimple / erldns

88%

LAST BUILD ON BRANCH main

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• automatic-dependencies-update
• autostart-listeners
• backpressure
• basic_ent_implementation
• bugfix/cache_put_rrset_accepts_zone_record
• bugfix/case_clause_not_normalised
• bugfix/rrsig_timestamp
• bugfix/rrsig_ttls
• bugfix/udp_payload_size
• chore/eunit_to_ct
• chore/improvements
• chore/minor
• chore/release
• chore/remove_rfc_compliant_ent_flag
• chore/reorganise_listeners_helpers
• chore/root_hints
• chore/simplify_code
• chore/simplify_restart_query
• chore/upgrade_dependencies
• chore/zone_cache_performance_and_correctness
• chores
• ci
• cleanup_extra_modules
• cleanups
• dependabot/github_actions/actions/cache-5
• dependabot/github_actions/actions/cache-6.1.0
• dependabot/github_actions/actions/checkout-5
• dependabot/github_actions/actions/checkout-6
• dependabot/github_actions/actions/checkout-7
• dependabot/github_actions/nosborn/github-action-markdown-cli-3.5.0
• dependencies
• deps/upgrade_dns_erlang
• design
• dnssec-issue
• dnstest
• docs-admin
• docs/contributing
• documentation
• edns0_truncated_record
• empty-rrsig
• ensure_counters_are_labels
• ent-rfc
• erldns_handler
• erldns_txt_removal
• event_handler
• expand_linter
• feat/admin_api
• feat/custom-admin-api-middlewares
• feat/dns_erlang_encoder_decoders
• feat/ed25519_ed448
• feat/modern_tcp
• feat/new_record_types
• feat/pipeline_continuations
• feat/pipeline_improvements
• feat/svcb_https
• feat/types_and_linters
• feat/udp_acceptors_congestion
• feat/udp_worker_codel
• feat/zone_cache_cleanup_and_telemetry
• feat/zonefiles
• feature/cds-cdnskey-ksk-rrsig
• fix-zonecut-cname-chain-truncation
• fix/infinite_delegation_loop
• fix/map_nsec_rr_types
• fix/restart_delegated_query
• fix/support_keyNNNN_in_svcb_https
• fix/svcb_https_encoding_dots
• fix/svcb_none
• fix/tcp_gen_server_loop
• fix/zone_load_on_init
• fix/zonefile_load
• fix_flaky_test
• fix_min_packet_size
• fixes
• handlers_improvements
• improvements
• linting
• logger
• logger_domains
• mailbox_lengths
• main
• metrics
• network/tcp
• network_performance
• nsec/custom-handlers
• nsec/implementation
• nsec/preparations
• packet_cache_rework
• perf/calibrate_min_heap_size
• perf/minor_optimisations
• pipeline_exception_telemetry
• pipelines
• pipelines_question_filter
• prepare-v9
• prepare-v9-rc1
• prepare-v9-rc2
• prepare_v7
• refactoring/dns_erlang
• release
• release-8.0
• release/v10
• remove-erldns-handler
• remove-spf-support
• resolver_split
• rfc8914-ede
• singletons
• soa-cache
• support-ecdsa
• task/bump-dnstest
• test/zonecut-cname-chain-edge-cases
• throttle_table_rework
• throws_as_errors_mangling
• tlsa
• tmp
• update_dns_erlang
• upgrade_deps
• upgrade_plugins_and_deps
• v8-rc6
• zone/cache
• zone/cleanups
• zone/codec
• zone/loader
• zones

Build # 28653118432

Build Type

push

github

Committed by web-flow

Commit Message

Remove erldns_handler; add DNSSEC NSEC type-mapper extension (#355)

* Remove erldns_handler; add DNSSEC NSEC type-mapper extension

The packet_handlers mechanism (erldns_handler: handle/4, filter/1, and the
custom-handler dispatch inside erldns_resolver) is removed in favour of a single
extensibility mechanism: erldns_pipeline stages. Custom record types are now
handled entirely by pipeline stages placed after the resolver.

The one part of erldns_handler that was not dead -- the NSEC type-mapper registry
DNSSEC uses to widen NSEC type bitmaps for custom record types -- is replaced by a
pipeline-opts extension API on erldns_dnssec:

  - add_nsec_type_mapper/3: a stage registers, from its own prepare/1, how a custom
    record type widens the NSEC bitmap. Mappers are folded into the nsec_type_mappers
    opts map and read by call/2 as a plain map lookup -- no persistent_term registry,
    no gen_server hop.
  - erldns_dnssec:prepare/1 guarantees the key is present (non-clobbering, since it
    runs after the contributing stages) so call/2 matches it without a hot-path default.

erldns_resolver no longer dispatches custom handlers: ANY queries use the matched
records directly and a no-type-match returns NODATA. The erldns_handler worker is
removed from the pipeline supervisor.

Tests: handler_SUITE removed; resolver_SUITE/dnssec_SUITE no longer start
erldns_handler; dnssec_SUITE gains coverage for add_nsec_type_mapper/3 and
map_nsec_rr_types/3.

* Upgrade dependencies and prepare changelog

Coverage Stats

17 of 17 new or added lines in 2 files covered. (100.0%)

1673 of 1907 relevant lines covered (87.73%)

4340.47 hits per line