dnsimple / erldns
88%

DEFAULT BRANCH: main
Repo Added
Token wBQTQ115twBLBos5bdaEOHuoBFllVtRjX regen
Build 543 Last
Files 49
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 87.686% (-0.004%) from 87.69%
30259461111

push

github

web-flow 
Portable listeners (#358)

* test: reserve ports instead of hardcoding them

Ports 8053, 8054 and 8083 were fixed constants, so two suites bound the same
port and any of them could collide with whatever else is on the host, or with
the ranges Windows reserves for dynamic allocation.

Listeners that no test sends traffic to now use port 0. The rest need a known
port on both UDP and TCP, which port 0 cannot give since each protocol would
resolve its own, so app_helper:reserve_port/0 picks a free one instead.

* test: read a UDP listener's socket through an accessor

Finding the port of a UDP listener meant reaching into a gen_server's state
and pulling the socket out by tuple position, which breaks silently the moment
a field is added or reordered.

The acceptor answers get_socket/1 instead, so callers ask the module rather
than knowing its call protocol. Both it and the module are -doc false, so
nothing is added to the public API, and the lookup loses three levels of
nesting that only existed to turn a bad match into a named error.

* feat: support Windows, FreeBSD, OpenBSD and NetBSD

erldns did not boot on Windows (#357), and nothing noticed because nothing
had ever run there. Three socket options were at fault, each in a different
way, and finding them needed CI on the platforms themselves.

`ipv6_v6only` cannot be unset on Windows or OpenBSD, so a wildcard listener
never bound: it now binds IPv4 there and warns, naming `::` as the way to
serve IPv6. Windows cannot bind a second socket to a port already in use, so
listeners there run one acceptor and one listen socket whatever
`parallel_factor` says. `reuseport_lb` is FreeBSD's own option and is sent
only there; Linux tolerated it only because it maps onto `reuseport`.

FreeBSD needed more than options. `SO_REUSEPORT_LB` does not balance IPv4
arriving v4-mapped on a dual-stack socket, so every query reached one socket
and a native IPv4 socket received four times as much. A wildcard listener
there no... (continued)

53 of 59 new or added lines in 7 files covered. (89.83%)

40 existing lines in 5 files now uncovered.

1709 of 1949 relevant lines covered (87.69%)

5628.93 hits per line

Relevant lines Covered
1949 RELEVANT LINES 1709 COVERED LINES
5628.93 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
30259461111 main Portable listeners (#358) * test: reserve ports instead of hardcoding them Ports 8053, 8054 and 8083 were fixed constants, so two suites bound the same port and any of them could collide with whatever else is on the host, or with the ranges Wind... push web-flow github
87.69
30254071350 main Update dns_erlang push NelsonVides github
87.69
30162069703 fix/os-socket-portability Merge 22d41df95 into 6ea677386 Pull #358 web-flow github
87.69
30162016514 main Find the OPT RR anywhere in the additional section (RFC 6891 §6.1.1) (#359) * Upgrade dns_erlang * Find the OPT RR anywhere in the additional section (RFC 6891 §6.1.1) RFC 6891 §6.1.1: an OPT RR "MAY be placed anywhere within the additional dat... push web-flow github
87.69
30161936802 fix/optrr-anywhere-in-additional Merge 42f5ed072 into b7524319d Pull #359 web-flow github
87.72
30161827488 fix/optrr-anywhere-in-additional Merge 1a80dfe22 into b7524319d Pull #359 web-flow github
87.69
29687713207 fix/os-socket-portability Merge 1c8836143 into b7524319d Pull #358 web-flow github
87.54
29687350799 fix/os-socket-portability Merge 3f92e90d1 into b7524319d Pull #358 web-flow github
87.7
29687036769 fix/os-socket-portability Merge 18bb849e0 into b7524319d Pull #358 web-flow github
87.61
29686266451 fix/os-socket-portability Merge ba98615ae into b7524319d Pull #358 web-flow github
87.7
See All Builds (536)

Badge your Repo: erldns

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh