decentraland / world-storage-service
99%

DEFAULT BRANCH: main
Repo Added
Files 58
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 98.679% (-0.001%) from 98.68%
32378180676

push

github

web-flow 
fix(auth): upgrade @dcl/crypto-middleware to 6 (#116)

* fix(auth): upgrade @dcl/crypto-middleware to 6

@dcl/crypto-middleware 6 changes the signed payload wire format: method,
path and timestamp are lowercased individually and the metadata is joined
verbatim, instead of lowercasing the whole joined string. Metadata casing
is now covered by the signature.

No source changes were needed. The middleware hands handlers the metadata
with its original casing both before and after, so the scene gate in
routes.ts and every authMetadata read behave identically.

Bump decentraland-crypto-fetch to 3, the client half of the same format
change. It signs every integration request, so without it the suite would
sign the old payload and get a 401 from a correctly-working server.

Update test/integration/auth/canonical-signer.spec.ts:

- Metadata re-cased after signing is now refused by signature
  verification (401 Invalid signature) instead of the canonical-value
  guard (400 Invalid chain metadata). Same request, same refusal, one
  layer earlier.
- A whitespace-padded scene signer is no longer refused at all. Version 6
  drops the canonical-value guard, and binding the metadata bytes to the
  signature does not cover a value that was already padded when signed,
  so it passes the strict `!==` in routes.ts and is served as an ordinary
  user-signed request. The tests now pin that behaviour and flag the gap.

* test(auth): state why the padded-signer change is not an escalation

The comment framed the dropped canonical-value guard as a reopened gap,
which reads as a call to restore it. Producing a padded signer requires
holding the identity key, and a key holder can already omit the field
entirely — 5.1.0 allowed that too, since its guard only inspected string
values. The guard covered one spelling of a self-declared label while
leaving omission open.

Records the reasoning next to the cases that pin the behaviour.

* refactor(auth): use rejectIfSigner from crypto... (continued)

424 of 438 branches covered (96.8%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1145 of 1152 relevant lines covered (99.39%)

71.32 hits per line

Relevant lines Covered
1152 RELEVANT LINES 1145 COVERED LINES
71.32 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
32378180676 main fix(auth): upgrade @dcl/crypto-middleware to 6 (#116) * fix(auth): upgrade @dcl/crypto-middleware to 6 @dcl/crypto-middleware 6 changes the signed payload wire format: method, path and timestamp are lowercased individually and the metadata is jo... push web-flow github
98.68
32186315021 fix/crypto-middleware-6 refactor(auth): use rejectIfSigner from crypto-middleware 6.1 Replaces the hand-rolled scene gate, and closes the padded-signer gap this branch previously had to pin as accepted behaviour. rejectIfSigner refuses a `signer` that is not already ca... Pull #116 LautaroPetaccio github
98.68
32175811106 fix/crypto-middleware-6 test(auth): state why the padded-signer change is not an escalation The comment framed the dropped canonical-value guard as a reopened gap, which reads as a call to restore it. Producing a padded signer requires holding the identity key, and a ke... Pull #116 LautaroPetaccio github
98.68
32175632922 fix/crypto-middleware-6 fix(auth): upgrade @dcl/crypto-middleware to 6 @dcl/crypto-middleware 6 changes the signed payload wire format: method, path and timestamp are lowercased individually and the metadata is joined verbatim, instead of lowercasing the whole joined st... Pull #116 LautaroPetaccio github
98.68
31742653884 1.6.1 fix: route ENS worlds through world permission checks (#115) * fix: route ENS worlds through world permission checks isDclWorldName matched only the `.dcl.eth` suffix, but worlds-content-server treats any `.eth` name as a world and resolves its ... push web-flow github
98.68
31742276244 main fix: route ENS worlds through world permission checks (#115) * fix: route ENS worlds through world permission checks isDclWorldName matched only the `.dcl.eth` suffix, but worlds-content-server treats any `.eth` name as a world and resolves its ... push web-flow github
98.68
31740198275 fix/ens-world-realm-routing test: tighten ENS world assertions and document realm classification The ENS non-owner case asserted that LAND ownership at the base parcel does not grant, but nothing primed LAMBDAS to return a positive permission, so it passed whether or not th... Pull #115 LautaroPetaccio github
98.68
31726215341 fix/ens-world-realm-routing fix: route ENS worlds through world permission checks isDclWorldName matched only the `.dcl.eth` suffix, but worlds-content-server treats any `.eth` name as a world and resolves its owner on chain (name-ownership.ts routes `.eth && !.dcl.eth` to ... Pull #115 LautaroPetaccio github
98.68
31192501471 main fix: reject non-canonical metadata signer and intent (#114) Bump @dcl/crypto-middleware from ^4.1.1 to ^5.1.0, which requires the top-level `signer` and `intent` metadata fields to arrive already trimmed and lowercased. The signed-fetch payload ... push web-flow github
98.68
31187258617 fix/canonical-signer-validation fix: reject non-canonical metadata signer and intent Bump @dcl/crypto-middleware from ^4.1.1 to ^5.1.0, which requires the top-level `signer` and `intent` metadata fields to arrive already trimmed and lowercased. The signed-fetch payload is lowe... Pull #114 cyaiox github
98.68
See All Builds (178)