decentraland / world-storage-service / 32186315021

99%

main: 99%

Pull #116

github

refactor(auth): use rejectIfSigner from crypto-middleware 6.1

Replaces the hand-rolled scene gate, and closes the padded-signer gap this
branch previously had to pin as accepted behaviour.

rejectIfSigner refuses a `signer` that is not already canonical instead of
comparing it, so a padded or re-cased value no longer reads as "not the
scene signer" and slip past. Nothing is folded — the value is rejected,
not rewritten — which keeps the canonical contract on the client where it
belongs while making the gate reliable here.

Two expectations move as a result, both from 404/401 to a 400 at the gate:
the padded cases are now refused rather than served, and the
re-cased-after-signing case is caught by the validator before signature
verification rather than by the signature a step later. Both refuse the
request either way; the gate is simply earlier and runs no crypto.

424 of 438 branches covered (96.8%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1145 of 1152 relevant lines covered (99.39%)

71.32 hits per line