craigcitro / apitools

87%

master: 89%

LAST BUILD ON BRANCH encoding_bug

branch: encoding_bug

CHANGE BRANCH

x

Reset

• encoding_bug
• adc
• binary_py3
• bounds
• callbacks
• chunked_download
• cleanup
• cleanup_tox
• dedep
• doubled
• encoding
• fastlint
• fix
• fix_coverage
• flags
• gce_cleanup
• gen_client_fix
• genpip
• internal_hooks
• lint
• master
• metaclass
• metadata
• mimetype
• more_pip
• morelogging
• oauth2client
• oauth2l
• protorpc_lite
• py35
• register_creds
• release
• scopes_arg
• service
• six_dep
• storage_cleanup
• trav
• urls
• utilfix
• v0.4.1
• v0.4.10
• v0.4.11
• v0.4.2
• v0.4.3
• v0.4.4
• v0.4.8
• v0.4.9
• v0.5.0
• v0.5.1
• v0.5.2
• v0.5.4

Build # 191

Build Type

push

travis-ci

Committed by craigcitro

Commit Message

Fix a nasty encoding corner case with JsonValue.

The json encoding code in protorpc had a bit of custom logic to handle the
case of repeated vs. non-repeated fields with the same line of code. However,
in the case of a JsonValue (aka `any` type in a discovery doc), it's possible
for a non-repeated value to itself be a list. In this case, we'd always
deserialize the whole list, and then ... only use the last value.

The fix here is to actually simplify the code a bit, and split the logic based
on whether the field is repeated, *not* whether the value is itself a list.

Also added a simple test.

Run Details

13 of 13 new or added lines in 2 files covered. (100.0%)

8106 of 9280 relevant lines covered (87.35%)

0.87 hits per line