craigcitro / apitools

77%

master: 89%

LAST BUILD ON BRANCH gen_client_fix

branch: gen_client_fix

CHANGE BRANCH

x

Reset

• gen_client_fix
• adc
• binary_py3
• bounds
• callbacks
• chunked_download
• cleanup
• cleanup_tox
• dedep
• doubled
• encoding
• encoding_bug
• fastlint
• fix
• fix_coverage
• flags
• gce_cleanup
• genpip
• internal_hooks
• lint
• master
• metaclass
• metadata
• mimetype
• more_pip
• morelogging
• oauth2client
• oauth2l
• protorpc_lite
• py35
• register_creds
• release
• scopes_arg
• service
• six_dep
• storage_cleanup
• trav
• urls
• utilfix
• v0.4.1
• v0.4.10
• v0.4.11
• v0.4.2
• v0.4.3
• v0.4.4
• v0.4.8
• v0.4.9
• v0.5.0
• v0.5.1
• v0.5.2
• v0.5.4

Build # 130

Build Type

push

travis-ci

Committed by craigcitro

Commit Message

Fix an issue with client generation, and a test.

Previously, the test of client generation was failing, as the exit code for
`./<generated_cli> help` was indistinguishable from a real error. This only
showed up as output running tests.

First, we fix the test by checking the output for a traceback. Not foolproof,
but a good start.

Next, we fix the code itself, by no longer letting `--outdir` be used as the
value for `--root_package_dir`. We have both flags; it's a bit silly to have
wacky logic that tries to use the value of one to outsmart the caller.
Instead, we're explicit, and if we have to repeat ourselves, no big deal. This
also allows us to delete `apitools.gen.util.GetPackage`.

Run Details

8 of 8 new or added lines in 1 file covered. (100.0%)

4679 of 6061 relevant lines covered (77.2%)

0.77 hits per line