craigcitro / apitools

86%

master: 89%

LAST BUILD ON BRANCH binary_py3

branch: binary_py3

CHANGE BRANCH

x

Reset

• binary_py3
• adc
• bounds
• callbacks
• chunked_download
• cleanup
• cleanup_tox
• dedep
• doubled
• encoding
• encoding_bug
• fastlint
• fix
• fix_coverage
• flags
• gce_cleanup
• gen_client_fix
• genpip
• internal_hooks
• lint
• master
• metaclass
• metadata
• mimetype
• more_pip
• morelogging
• oauth2client
• oauth2l
• protorpc_lite
• py35
• register_creds
• release
• scopes_arg
• service
• six_dep
• storage_cleanup
• trav
• urls
• utilfix
• v0.4.1
• v0.4.10
• v0.4.11
• v0.4.2
• v0.4.3
• v0.4.4
• v0.4.8
• v0.4.9
• v0.5.0
• v0.5.1
• v0.5.2
• v0.5.4

Build # 179

Build Type

push

travis-ci

Committed by craigcitro

Commit Message

Fix an issue with Python3 multipart encodings.

As discovered in
https://github.com/GoogleCloudPlatform/gcloud-python/issues/1760, we were
mangling bytes when encoding them as part of a multipart upload request. The
fix is to switch from using `six.StringIO` to `six.BytesIO` in `transfer.py`.
The patch here is closely based on
https://github.com/GoogleCloudPlatform/gcloud-python/pull/1779.

Run Details

28 of 28 new or added lines in 2 files covered. (100.0%)

7881 of 9199 relevant lines covered (85.67%)

0.86 hits per line