• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

craigcitro / apitools / 189
87%
master: 89%

Build:
Build:
LAST BUILD BRANCH: dedep
DEFAULT BRANCH: master
Ran 17 Nov 2016 08:05AM UTC
Jobs 1
Files 60
Run time 9s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
189

push

travis-ci

craigcitro
Fix a nasty encoding corner case with JsonValue.

The json encoding code in protorpc had a bit of custom logic to handle the
case of repeated vs. non-repeated fields with the same line of code. However,
in the case of a JsonValue (aka `any` type in a discovery doc), it's possible
for a non-repeated value to itself be a list. In this case, we'd always
deserialize the whole list, and then ... only use the last value.

The fix here is to actually simplify the code a bit, and split the logic based
on whether the field is repeated, *not* whether the value is itself a list.

6 of 6 new or added lines in 1 file covered. (100.0%)

8099 of 9273 relevant lines covered (87.34%)

0.87 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
100.0
apitools/base/protorpclite/protojson.py

Uncovered Existing Lines

Lines Coverage ∆ File
3
100.0
apitools/base/protorpclite/protojson.py
Jobs
ID Job ID Ran Files Coverage
2 189.2 (TOX_ENV=py27) 17 Nov 2016 08:05AM UTC 0
87.34
Travis Job 189.2
Source Files on build 189
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #189
  • 012ac5e9 on github
  • Prev Build on encoding_bug (#188)
  • Next Build on encoding_bug (#190)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc