codeforamerica / ohana-web-search
96%
master: 98%

LAST BUILD BRANCH: mb-circle-ci
DEFAULT BRANCH: master
Repo Added
Files 26
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH refactor-error-handling
branch: refactor-error-handling
CHANGE BRANCH
x

1592

push

travis-ci

monfresh 
Refactor error handling. Closes #248.

 - Added alert-manager JS to app-init so that an alert can be dismissed
on any page.

- If geolocation fails and an alert is displayed, the “Services near
me” button text gets reverted back to its default instead of leaving it
showing “Please wait…”

- The most common exceptions (based on error logs from SMC-Connect) are
handled by application_controller and how each exception is handled can
easily be configured. By default, the user is redirected to either the
home page or the same page they were on, and an alert is displayed. The
text of the alert is customizable in `config/locales/en.yml` in the
`errors` section.

- By rescuing exceptions at the application level, we can clean up the
organizations model and controller code, and we also get rid of the
duplicate calls to the same location, which fixes #248.

- Now that the location details page is only making the 1 expected API
call, the `url_dynamic` cassette had to be fixed to only include 1
call. It was failing because the ERB was only applied to the second
call in the cassette.

- Refactored the alert HTML

- Set `config.consider_all_requests_local` to false in `test.rb` to
allow testing redirects and alerts when exceptions occur.
Note, to test this in development, you will need to set this same
setting to `false` in `development.rb`. When done testing, it should be
reverted back to `true`.

- Also closes #135.

33 of 33 new or added lines in 4 files covered. (100.0%)

230 of 240 relevant lines covered (95.83%)

42.21 hits per line

Relevant lines Covered
240 RELEVANT LINES 230 COVERED LINES
42.21 HITS PER LINE
Source Files on refactor-error-handling
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
1592 refactor-error-handling Refactor error handling. Closes #248. - Added alert-manager JS to app-init so that an alert can be dismissed on any page. - If geolocation fails and an alert is displayed, the “Services near me” button text gets reverted back to its default ins... push monfresh travis-ci pending completion  
See All Builds (1890)