codeforamerica / ohana-web-search
91%
master: 98%

LAST BUILD BRANCH: mb-circle-ci
DEFAULT BRANCH: master
Repo Added
Files 26
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH 365-map-infobox
branch: 365-map-infobox
CHANGE BRANCH
x

1431

push

travis-ci

anselmbradford 
Fixes #365 - Edit UX for results map

In this branch, @millerEric made some UX changes to the results map
view in response to Issue #365 ("Google Map rollover is cropped out of
view some times."). @millerEric used infoBox.js from the Google
Maps utility library, because it allows for easy customizability,
including position and styling. Presently, the infoBox is displayed to
the right of markers to decrease the likelihood of it being cropped out
of the window. The infoBox can be styled either within its options
object, or by linking to a CSS stylesheet. @anselmbradford moved all
styles to CSS.

- @millerEric set the marker's optimized property to false in order to
prevent events from propagating through the infoBox onto the map (e.g.
to prevent markers underneath an open infoBox from registering a
mouseover event).

- @anselmbradford added a z-index for the close box [x] per
@millerEric original edit, because it was visible but not clickable.

- infoBox.js requires the google maps api to be fully loaded before
it is loaded. This has presented some difficulties because of the
asynchronous loading of the google maps api. @anselmbradford nested the
dependencies so they loaded in order, which consequentially required
the result-map-manager to become self-executing, for better or worse.

@anselmbradford's commit also edits the following:

- Removes the clearMarkers method, which is only needed if the map results
were updated via ajax (which isn’t currently used).

- Removes the metadata and summary text variables, which were no longer
used.

- Adds additional code comments to the map manager code.

- Configures infobox states using a bit mask so that complex interactions
can be programmed as toggleable flags that are then evaluated for to determine
when to open or close the infobox.

- Configures jshint task to allow bitwise operations that are needed for
a bitmask.

- Adds additional styles to the infobox to make it more consistent with
links and other su... (continued)

237 of 261 relevant lines covered (90.8%)

56.34 hits per line

Relevant lines Covered
261 RELEVANT LINES 237 COVERED LINES
56.34 HITS PER LINE
Source Files on 365-map-infobox
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
1431 365-map-infobox Fixes #365 - Edit UX for results map In this branch, @millerEric made some UX changes to the results map view in response to Issue #365 ("Google Map rollover is cropped out of view some times."). @millerEric used infoBox.js from the Google Maps u... push anselmbradford travis-ci pending completion  
1430 365-map-infobox Style updates Adds corner arrow to info box so it’s clearer which marker the info box is pointing toward. push anselmbradford travis-ci pending completion  
1429 365-map-infobox Fixes #365 - Edit UX for results map In this branch, @millerEric made some UX changes to the results map view in response to Issue #365 ("Google Map rollover is cropped out of view some times."). @millerEric used infoBox.js from the Google Maps u... push anselmbradford travis-ci pending completion  
1428 365-map-infobox Formatting updates - Removes clearMarkers method, which is only needed if the map results are updated via ajax (which isn’t currently used) - Removes the metadata and summary text variables, which were no longer used. - Adds additional code comme... push anselmbradford travis-ci pending completion  
1427 365-map-infobox Fixes #365 - Edit UX for results map In this branch, @millerEric made some UX changes to the results map view in response to Issue #365 ("Google Map rollover is cropped out of view some times."). @millerEric used infoBox.js from the Google Maps u... push anselmbradford travis-ci pending completion  
1426 365-map-infobox Merge branch '365-map-infobox' of https://github.com/codeforamerica/ohana-web-search into 365-map-infobox Conflicts: app/assets/javascripts/result/result-map-manager.js push anselmbradford travis-ci pending completion  
1267 365-map-infobox Fixes #365 - Edit UX for results map In this branch, @millerEric made some UX changes to the results map view in response to Issue #365 ("Google Map rollover is cropped out of view some times."). I tried using infoBox.js from the Google Maps util... push anselmbradford travis-ci pending completion  
1263 365-map-infobox Merge pull request #397 from millerEric/infoBoxMap Edit the UX for results map view, using infoBox.js. push anselmbradford travis-ci pending completion  
1262 365-map-infobox Edit UX for results map view with infoBox.js. Pull #397 millerEric travis-ci pending completion  
1261 365-map-infobox Merge pull request #395 from codeforamerica/394-search-txt-alignment Fixes #394 - vertical align bug push anselmbradford travis-ci pending completion  
See All Builds (1890)