codeforamerica / ohana-web-search

96%

master: 98%

LAST BUILD ON BRANCH ie-upgrades

branch: ie-upgrades

CHANGE BRANCH

x

Reset

• ie-upgrades
• 220-email-link
• 239-apple-icons
• 289-lang-links-footer
• 300-add-get-link
• 304-return-false-ie
• 306-rails4-upgrade
• 323_remove_phone_hours
• 335-geolocate-btn-style
• 336-remove-hardcoded-smc-code
• 338-map-icon-sizes
• 365-map-infobox
• 377-ga-fix
• 378-fallback-css
• 379-open-sauce-integration
• 384-code-cleanup
• 387-summary-bug
• 389-update-tests
• 394-search-txt-alignment
• 396-input-line-height
• 399-travis-pr-failures
• 402-coordinates
• 409-polyfill-refactor
• 410-contributing-md
• 411-ask-for-field
• 414-rubocop-integration
• 415-vanity-phone-number
• 417-change-type-to-number_type
• 421-use-test-key-in-application-yml
• 423-fix-search-input-fields
• 424-css-alignment
• 436-fax-text
• 439-optimize-js-placement
• 440-rails-41-upgrade
• 442-cucumber-cleanup
• 446-upgrade-google-analytics
• 447-cfa-flag
• 459-google-translate-customization
• 463-cuddle-js
• 464-refactor-color-variables-take-two
• 468-top-align-superscript
• 476-adds-missing-details
• 484-adds-applicationjs
• 486-links-for-no-results
• 495-clear-button
• 496-floating-header
• 498-adds-graphic-templates
• 499-pagination-links
• 507-character-limiter
• 517-search-address
• 519-upgrade-rspec
• 526-add-tab-index
• 526-tab-index
• 526-tab-index-helper
• 546-remove-title-attr
• 547-geolocation-btn-disable
• 551-remove-gsub
• 552-requirejs-gem-update
• 554-default-location-text
• 565-remove-server-cookie
• 569-cuddle-css
• 571-last-modified
• 573-browser-upgrade-alert
• 582-maps-api-key
• 589-ie-input
• 590-popup-types
• 612-map-size-setting
• 622-rename-token
• 623-json-type
• 632-terminology-link
• 635-terminology-box-position
• 644-update-fields
• 645-utility-link-module
• 649-org-details
• 651-poi-details-map
• 663-phone-types-results
• 667-new-service-fields
• 671-schedules
• 686-desc-whitespace
• 705-rename-js
• 713-right-margin
• 716-jshint-offenses
• 724-extra-space
• 726-interpretation-services
• 729-test-echo
• 730-over-quota
• 731-translation-customization
• 738-sms
• 743-fix-long-cache-key
• 782-custom-translations
• 811-downgrade-requirejs-rails
• add-bootstrap-script
• add-bummr
• add-codeclimate
• add-docker-support
• add-hackrequest-link
• add-jshint-to-script-test
• add-please-wait-to-geolocate-button-481
• add-profiling-gems
• add-reek-engine
• addeventlistener-module
• alert-css-cleanup
• alert-manager-update
• allow-travis-to-run-from-external-prs
• api-updates
• applicationjs-all-routes
• box-shadow
• clean-up-vcr
• clear-all-button
• code-cleanup
• code-comments
• convert-application-layout-to-haml
• css-assets-partial
• css-filenames
• css-linting
• css-refactor
• css-updates
• default-hide-geolcation
• depfu/update/capybara-3.4.1
• depfu/update/google-api-client-0.23.4
• depfu/update/puma-3.12.0
• depfu/update/reek-5.0.2
• depfu/update/rubocop-0.58.1
• depfu/update/rubocop-0.58.2
• depfu/update/uglifier-4.1.15
• depfu/update/uglifier-4.1.16
• depfu/update/webpacker-3.5.5
• depfu/update/yard-0.9.15
• detail-map-complexity
• detail-map-refactor
• do-not-use-token-for-tests
• eliminate-main-css
• enable-https-setting
• environment-vars
• exclude-wad-from-coveralls
• fax-appearance
• filter-cleanup
• fix-asset-pipeline
• fix-bootstrap
• fix-caching
• fix-etag
• fix-heroku-middleware-issue
• fix-translation-spec
• fixes-issues
• font-awesome-sass
• geolocate-refactor
• google-translate-dropdown
• graphics-file-layer-names
• heroku-deploy-script
• hotfix-async-plugin
• hound-config
• http-caching
• ie-style-separation
• ignore-ssl-errors-for-phantomjs
• jquery_ujs
• js-code-comment
• js-utility-updates
• jshint
• jshint-adjustments
• jshint-cleanup
• lang-link-tweak
• link-to-admin-site-351
• logo-source
• map-feature-update
• map-loading-updates
• map-manager-refactor
• map-markers-assets
• map-rendering-update
• master
• mb-better-webpacker-diff
• mb-circle-ci
• mb-fix-rubocop
• mb-gmaps-api-key
• mb-keyword-translator
• mb-remove-jquery-dependency
• mb-remove-rails-12-factor
• mb-update-app-json
• mb-update-codeclimate
• mb-update-gems
• mb-update-ruby
• mb-use-webpacker
• minor-readme-update
• poltergeist
• postgres
• print-styles
• refactor-and-customize-pagination
• refactor-error-handling
• refactor-search-results-presentation
• refactor-translation
• remove-alert-link-underline
• remove-contrib
• remove-kind
• remove-readme-ruby-section
• remove-unused-js
• remove-unused-module-ref
• remove-unused-util
• removes-json-gem
• removes-nearby-map-logic
• removes-teaspoon
• replace-mandrill-with-sendgrid
• rubocop-style-updates
• sass-docs
• sass-refactor
• set-tz-env-var
• setup-instructions
• simplify-filters
• site-links
• snyk-fix-6mlrps
• snyk-fix-ypyrcz
• spec-code-comments
• style-guide
• test-cleanup
• test-refactor
• test-script
• trailing-space
• transpec
• update-better_errors
• update-bummr
• update-caching
• update-close-btn-name
• update-coveralls
• update-faraday-http-cache
• update-field-names
• update-figaro
• update-figaro-gem
• update-font-awesome
• update-font-awesome-rails
• update-gems
• update-google-api
• update-google-api-client
• update-google-client
• update-haml-lint
• update-haml-rails
• update-jshint
• update-jshint-gem
• update-kgio
• update-nokogiri
• update-ohanakapa
• update-rack-rewrite
• update-rails
• update-rails_12factor
• update-readme
• update-readme-stack
• update-rubocop
• update-ruby
• update-sass-rails
• update-spring
• update-uglifier
• update-vcr
• updates-cassettes
• updates-coveralls
• updates-haml-rails
• updates-kaminari
• updates-modernizr
• updates-poltergeist
• updates-puma
• updates-rspec-rails
• updates-rubocop
• updates-spring
• updates-uglifier
• upgrade-better_errors
• upgrade-capybara
• upgrade-chunky_png
• upgrade-coveralls
• upgrade-gems
• upgrade-haml-lint
• upgrade-rspec-rails
• upgrade-rubocop
• upgrade-ruby-211
• upgrade-spring
• upgrade-vcr
• upgrade-webmock
• upgrade-yard
• use-different-label-for-location-hours
• use-https-for-fonts
• use-railties
• use-test-app-for-specs
• use-travis-caching
• xit-filter-specs

Build # 1853

Build Type

push

travis-ci

Committed by anselmbradford

Commit Message

Refactors JS utilities; separates IE concerns

- Removes unused util/util methods.
- Moves cookie code to its own CRUD module.
- Fixes #565 - Removes server-side handling of Google Translate cookie
and consolidates cookie handling in google-translate-manager.
- Moves isTranslated method to google-translate-manager.
- Updates “close” button method to “clear” to go with new naming.
- Pads header popup title text so (x) button doesn’t risk overlapping.
- Gives alert close button min height/width so that size doesn’t change
as (x) icon is loading.
- Implements addEventListener on alert so events can be attached to it
being dismissed.
- Creates IE8-specific override stylesheet and pulls :before and :after
selectors out of main stylesheet into this one. Also provides overrides
to elements that have box-shadows but no border by providing a border
instead (alert and popup).
-

Run Details

235 of 246 relevant lines covered (95.53%)

64.8 hits per line