codeforamerica / ohana-web-search
90%
master: 98%

LAST BUILD BRANCH: mb-circle-ci
DEFAULT BRANCH: master
Repo Added
Files 26
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH map-feature-update
branch: map-feature-update
CHANGE BRANCH
x

1461

push

travis-ci

anselmbradford 
Moves Google Maps plugins to be inline and Code Cleanup

The plugins work fine locally using nested require() calls. However, when
using the requirejs optimizer, the plugins were concatenated in the main
application script, whereas Google Maps API is loaded asynchronously. This
led to errors in production because the local concatenated plugins were
executing before their dependencies loaded. Having the plugins inline isn't
ideal, but based on research it appears to be the approach with the least
overhead and disruption of the existing site structure.

It allows:
- Guaranteed execution of the plugins after the Google Maps APIs have loaded.
- Exposure of the module initialization method to the outside. With a nested
require() call inside the module, the init method was not accessible outside
the module scope. As inline plugins the init method is accessible again and
can be used to specify where and when the module is initialized.
- Removal of vendor scripts and the associated path settings in the
requirejs.yml config file.

Alternatives to this setup that could be investigated in the future:
(a) The Promises based approach shown here
http://stackoverflow.com/questions/12648598/amd-version-of-google-maps-v3-for-use-with-require-js/
The consequences of this approach are the introduction of a jQuery dependency
for the loading and possible non-support for Promises in IE being an issue.

(b) Include directive. See
http://stackoverflow.com/questions/19337293/requirejs-optimiser-include-nested-dependencies-for-certain-files-and-folders
The plugins could still be nested like how they were set up and worked locally
and then explicitly included in the build. However, this may still cause them
to load before the maps, so that would need to be investigated on a staging
server.

Other cleanup and adjustments:

- Adds findNestedDependencies flag to requirejs config. Nested require
calls were not being included in the optimizer.

- Removes erroneous reference to term-... (continued)

1 of 1 new or added line in 1 file covered. (100.0%)

222 of 246 relevant lines covered (90.24%)

57.63 hits per line

Relevant lines Covered
246 RELEVANT LINES 222 COVERED LINES
57.63 HITS PER LINE
Source Files on map-feature-update
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
1461 map-feature-update Moves Google Maps plugins to be inline and Code Cleanup The plugins work fine locally using nested require() calls. However, when using the requirejs optimizer, the plugins were concatenated in the main application script, whereas Google Maps API... push anselmbradford travis-ci pending completion  
1459 map-feature-update Cleanup push anselmbradford travis-ci pending completion  
1458 map-feature-update Fixes push anselmbradford travis-ci pending completion  
1457 map-feature-update Fixes push anselmbradford travis-ci pending completion  
1455 map-feature-update Fixes push anselmbradford travis-ci pending completion  
1454 map-feature-update Fixes push anselmbradford travis-ci pending completion  
1453 map-feature-update Fixes push anselmbradford travis-ci pending completion  
1452 map-feature-update Code cleanup Fixes bug where missing address caused error The code was looking for coordinates key being present, but didn’t care if it was nil, which led to an error if it was. Adds additional code documentation and removes unused code. push anselmbradford travis-ci pending completion  
1450 map-feature-update Fixes push anselmbradford travis-ci pending completion  
1449 map-feature-update Fixes push anselmbradford travis-ci pending completion  
See All Builds (1890)