chideat / valkey-operator

24%

main: 22%

LAST BUILD ON BRANCH fix/reconcile-builder-correctness-bugs

branch: fix/reconcile-builder-correctness-bugs

CHANGE BRANCH

x

Reset

• fix/reconcile-builder-correctness-bugs
• chore/deps-combined-2026-03-16
• chore/resolve-deps-prs
• copilot/add-helm-chart-support
• copilot/fix-github-actions-permissions
• dependabot/github_actions/actions/setup-go-5
• dependabot/go_modules/github.com/alicebob/miniredis/v2-2.35.0
• dependabot/go_modules/github.com/fsnotify/fsnotify-1.8.0
• dependabot/go_modules/github.com/fsnotify/fsnotify-1.9.0
• dependabot/go_modules/github.com/samber/lo-1.49.1
• dependabot/go_modules/github.com/stretchr/testify-1.10.0
• dependabot/go_modules/gotest.tools/v3-3.5.2
• dev
• docs-optimize
• docs-supported-versions-matrix
• feat/1.1.0
• fix-kustomize-deployment
• fix/cross-version-rolling-upgrade-data-loss
• fix/pr-pipeline-fork-prs
• fix/safe-version-configmap
• main
• release-1.0
• renovate/alpine-3.x
• renovate/configure
• renovate/patch-kubernetes
• renovate/patch-patch-upgrades
• test-fix
• update-docs
• update-valkey-examples
• valkey-version-support

Build # 27890096313

Build Type

Pull #96

github

Committed by chideat

Commit Message

refactor(test): share FailoverInstance/ValkeyNode fakes; simplify size guard

Addresses code-review follow-ups (all test-only / no production behavior change):

- add internal/testutil with configurable FakeFailoverInstance and
  FakeValkeyNode, replacing three near-identical per-package mocks
  (failoverbuilder, ops/failover/actor, valkey/failover/monitor). The
  certmetav1.ObjectReference deprecation now surfaces once instead of 3x.
- simplify exceedsConfigMapSizeLimit to take a single dataSize (oldTotal and
  oldData always cancelled to 0 at the only call site); behavior unchanged.

Verified: ACL-rule validation is fully handled by pkg/types/user.Rule.Validate
(user webhook + pkg/security/acl), so the earlier dead-code removal left no gap.

Full unit suite incl. envtest is green.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Pull Request Pull Request #96: fix: reconcile/builder correctness bugs with unit tests

Coverage Stats

15 of 17 new or added lines in 11 files covered. (88.24%)

4844 of 20538 relevant lines covered (23.59%)

0.27 hits per line