chideat / valkey-operator

22%

main: 22%

Pull #77

github

fix: correct RDS Valkey webhook registration and failover defaults

Two bugs in the RDS Valkey admission webhook:

1. Webhook annotations referenced the wrong API group (rds.inst.buf.red
   instead of rds.valkey.buf.red), causing both the mutating and validating
   webhooks to never fire for Valkey CR operations. This meant the sentinel
   access serviceType was never propagated from spec.access.serviceType to
   spec.sentinel.access.serviceType, resulting in sentinel services always
   being ClusterIP even when NodePort was requested.

2. For ValkeyFailover arch, spec.replicas.shards was only defaulted to 1
   when spec.replicas was nil. If the user provided a Replicas object with
   only ReplicasOfShard set, Shards defaulted to 0 and the validating webhook
   would reject the CR. Fixed by always enforcing Shards=1 for failover,
   matching the existing ValkeyReplica behavior.

1 of 1 new or added line in 1 file covered. (100.0%)

4616 of 20613 relevant lines covered (22.39%)

0.26 hits per line