chideat / valkey-operator / 27875628579

24%

main: 22%

Build Type

Pull #96

github

Committed by chideat

Commit Message

fix: correct a batch of reconcile/builder correctness bugs with tests

Surgical, behavior-preserving fixes (no new logic), each with a unit test.

- ops/failover patch-labels: add missing `return` so a Monitor().Master()
  error no longer falls through to a nil-pointer panic
- valkey/failover manual monitor: return nil on successful promotion instead
  of falling through to the "No available node to failover" error
- clientset UpdatePod: submit the merged oldPod (with server ResourceVersion),
  not the caller's stale pod argument
- builder configmap (cluster+failover): fix memory-sizing guard `&&`->`||` so
  the Limits->Requests memory fallback actually fires
- controller failover: return after finalizer removal so it is not re-added to
  an object being deleted (mirrors cluster_controller)
- config.Getenv: return the matched non-empty default, not always defaults[0]
- rds webhook: correct the inverted "spec.resources is required" message
- builder statefulset (cluster+failover): set PVC OwnerReferences via index so
  RetainAfterDeleted is honored (range-copy bug)
- helper sync: fix etcd object-size guard constant (~1Gi -> ~1Mi) via a small
  pure `exceedsConfigMapSizeLimit` helper
- remove dead util.CheckRule/CheckUserRuleUpdate/AuthConfig and their tests

Full unit suite incl. envtest (controller/webhook) is green.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Pull Request Pull Request #96: fix: reconcile/builder correctness bugs with unit tests

Coverage Stats

15 of 17 new or added lines in 11 files covered. (88.24%)

6 existing lines in 1 file now uncovered.

4844 of 20539 relevant lines covered (23.58%)

0.27 hits per line